diff options
author | W. J. van der Laan <laanwj@protonmail.com> | 2021-11-09 14:05:47 +0100 |
---|---|---|
committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-11-09 14:12:41 +0100 |
commit | cb4adbd8ab1b3cc79650c56096a37b8cf1b45e58 (patch) | |
tree | 78c915ef0af543bc57aaad7991b5c4dfd93e531d /src/Makefile.test.include | |
parent | 55dd38552446840554bfd0babba3229f018f1b66 (diff) | |
parent | 79fd28cacbbcb86ea03d3d468845001f84a76de3 (diff) | |
download | bitcoin-cb4adbd8ab1b3cc79650c56096a37b8cf1b45e58.tar.xz |
Merge bitcoin/bitcoin#22934: Add verification to `Sign`, `SignCompact` and `SignSchnorr`
79fd28cacbbcb86ea03d3d468845001f84a76de3 Adds verification step to Schnorr and ECDSA signing (amadeuszpawlik)
Pull request description:
As detailed in #22435, BIP340 defines that during Schnorr signing a verification should be done. This is so that potentially corrupt signage does not leak information about private keys used during the process. This is not followed today as no such verification step is being done. The same is valid for ECDSA signing functions `Sign` and `SignCompact`.
This PR adds this missing verification step to `SignSchnorr`, `Sign` and `SignCompact`.
ACKs for top commit:
sipa:
utACK 79fd28cacbbcb86ea03d3d468845001f84a76de3
laanwj:
Code review ACK 79fd28cacbbcb86ea03d3d468845001f84a76de3
theStack:
re-ACK 79fd28cacbbcb86ea03d3d468845001f84a76de3
Tree-SHA512: 8fefa26caea577ae8631cc16c4e2f4cc6cfa1c7cf51d45a4a34165636ee290950617a17a19b4237c6f7a841db0e40fd5c36ad12ef43da82507c0e9fb9375ab82
Diffstat (limited to 'src/Makefile.test.include')
0 files changed, 0 insertions, 0 deletions