diff options
| author | fanquake <fanquake@gmail.com> | 2020-01-29 20:37:13 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-01-29 20:48:30 +0800 |
| commit | c434282d2cb816fd92f7e229385169e783c84fdd (patch) | |
| tree | c10574578fd587602de7b9ba021fa03ce7d2e8fe /src/Makefile.test.include | |
| parent | e061b8dc8fba9831db1f674bc1965244d3c11c19 (diff) | |
| parent | b35567fe0ba3e6f8d8f9525088eb8ee62065ad01 (diff) | |
Merge #18008: test: only declare a main() when fuzzing with AFL
b35567fe0ba3e6f8d8f9525088eb8ee62065ad01 test: only declare a main() when fuzzing with AFL (fanquake)
Pull request description:
This fixes fuzzing using [libFuzzer](https://llvm.org/docs/LibFuzzer.html) on macOS, which caused a few issues during the recent review club. macOS users could only fuzz using afl, or inside a VM.
It seems that the `__attribute__((weak))` marking is not quite enough to properly mark `main()` as weak on macOS. See Apples docs on [Frameworks and Weak Linking](https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/WeakLinking.html#//apple_ref/doc/uid/20002378-107262-CJBJAEID).
Have tested fuzzing using libFuzzer and AFL with this patch.
ACKs for top commit:
MarcoFalke:
ACK b35567fe0ba3e6f8d8f9525088eb8ee62065ad01
fjahr:
ACK b35567f
Tree-SHA512: b881fdd98c7e1587fcf44debd31f5e7a52df938059ab91c41d0785077b3329b793e051a2bf2eee64488b9f6029d9288c911052ec23ab3ab8c0561a2be1682dae
Diffstat (limited to 'src/Makefile.test.include')
0 files changed, 0 insertions, 0 deletions