diff options
author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-02-05 14:25:56 +0100 |
---|---|---|
committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-02-05 14:26:00 +0100 |
commit | 01668839de3693736c29be61c4330aea00bb0136 (patch) | |
tree | 82ed4e302d0a3e136bb2ba06bf23abb5ed984ff0 /share | |
parent | adea5e1b54cf5155b56bffe08af16538d5789c38 (diff) | |
parent | c0bc453135b3f549f800545075cb7bdb310c3ad4 (diff) |
Merge #17660: build: remove deprecated key from macOS Info.plist
c0bc453135b3f549f800545075cb7bdb310c3ad4 build: remove deprecated key from macOS Info.plist (fanquake)
Pull request description:
Note that the current release binaries show correct version numbers everywhere in the GUI and macOS info dialogs (except for when you "space" click the app, shown in screenshots), and we haven't reintroduced the issue that #14701 fixed. This is just swapping a deprecated field for a newer one, as well as using the entire version string in two fields that we hadn't been previously.
Follows up discussion in #14701.
0.19.0.1
![0 19 0 1](https://user-images.githubusercontent.com/863730/70089170-a0576e80-15e5-11ea-975c-a6902a1ed95a.png)
This PR.
![master](https://user-images.githubusercontent.com/863730/70089178-a3525f00-15e5-11ea-9d63-7db67de014a5.png)
ACKs for top commit:
laanwj:
ACK c0bc453135b3f549f800545075cb7bdb310c3ad4
Tree-SHA512: 6191056d0cb6072b8a2170c8441ebfe500cf00cd41014bf5ee68fbf60b5bb5642e2fad9541f1c5abfaafdae6db3102c3add6169cefce3fc4a63d8b913ea35865
Diffstat (limited to 'share')
-rw-r--r-- | share/qt/Info.plist.in | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/share/qt/Info.plist.in b/share/qt/Info.plist.in index 275078c88d..3befba3425 100644 --- a/share/qt/Info.plist.in +++ b/share/qt/Info.plist.in @@ -16,7 +16,7 @@ <key>CFBundlePackageType</key> <string>APPL</string> - <key>CFBundleGetInfoString</key> + <key>NSHumanReadableCopyright</key> <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@.@CLIENT_VERSION_BUILD@, Copyright © 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string> <key>CFBundleShortVersionString</key> |