diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-12-12 16:22:23 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-12-12 16:24:52 +0100 |
| commit | edc2822b9dc90af25750fd17c17c248490051431 (patch) | |
| tree | dab75d19de3fe68f53f4b6dae51232164ebab105 /share | |
| parent | 96bde4f01f418aff97d14adc0a0e51c81087557f (diff) | |
| parent | 8e209340c85fc2493d7d1d7affe7e316bb613cbd (diff) | |
| download | bitcoin-edc2822b9dc90af25750fd17c17c248490051431.tar.xz | |
Merge #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString
8e209340c85fc2493d7d1d7affe7e316bb613cbd build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (fanquake)
Pull request description:
As mentioned in #14697, if you download the `0.17.0.1` dmg, and inspect the `.app` bundle, the version in the GetInfo string reads `0.17.0`, which is confusing given you're expecting `0.17.0.1`:
<img width="391" alt="0 17 0 1" src="https://user-images.githubusercontent.com/863730/48300032-fbb54b00-e510-11e8-9bcd-77e1fffffc63.png">
This PR adds `CLIENT_VERSION_BUILD` to the string, so that the full version number is displayed, i.e:
<img width="327" alt="this pr" src="https://user-images.githubusercontent.com/863730/48300015-7893f500-e510-11e8-98b9-80424719a082.png">
Tree-SHA512: f553253d03283639cc4dda00c8004b5c63ae2b489762e5e8c666166e71b14e672792c1df678f87484d51d153b5781c5ec1b145774096600f504833024ae8baea
Diffstat (limited to 'share')
| -rw-r--r-- | share/qt/Info.plist.in | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/share/qt/Info.plist.in b/share/qt/Info.plist.in index abe605efd0..3cd130ce48 100644 --- a/share/qt/Info.plist.in +++ b/share/qt/Info.plist.in @@ -17,7 +17,7 @@ <string>APPL</string> <key>CFBundleGetInfoString</key> - <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@, Copyright © 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string> + <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@.@CLIENT_VERSION_BUILD@, Copyright © 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string> <key>CFBundleShortVersionString</key> <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@</string> |