diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2018-11-07 12:20:01 -0500 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2018-11-07 12:20:43 -0500 |
| commit | d26d15c6c89ad02c0a951d5242bcdd3f29096a31 (patch) | |
| tree | a16473e5a99202740de0aad3f3d0b8ff85a165ff /share | |
| parent | e8d490f27e691d8e5f6910f878c4f1c3c6ad788d (diff) | |
| parent | c82190cdb615caf589d2401cc1ae52ba40eba1a1 (diff) | |
| download | bitcoin-d26d15c6c89ad02c0a951d5242bcdd3f29096a31.tar.xz | |
Merge #14365: tests: Add Python dead code linter (vulture) to Travis
c82190cdb6 tests: Add Python dead code linter (vulture) (practicalswift)
590a57fdec tests: Remove unused testing code (practicalswift)
Pull request description:
Add Python dead code linter (`vulture`) to Travis.
Rationale for allowing dead code only after explicit opt-in (via `--ignore-names`):
* Less is more :-)
* Unused code is by definition "untested"
* Unused code can be an indication of bugs/logical errors. By making the contributor aware of newly introduced unused code it gives him/her an opportunity to investigate if the unused code they introduce is malignant or benign :-)
* Unused code is hard to spot for humans and is thus often missed during manual review
* [YAGNI](https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it)
Based on #14312 to make linter job pass.
Tree-SHA512: 4c581df7c34986e226e4ade479e0d3c549daf38f4a4dc4564b25564d63e773a1830ba55d1289c771b1fa325483e8855b82b56e61859fe8e4b7dfa54034b093b6
Diffstat (limited to 'share')
0 files changed, 0 insertions, 0 deletions