diff options
| author | Andrew Chow <achow101-github@achow101.com> | 2022-08-08 18:56:40 -0400 |
|---|---|---|
| committer | Andrew Chow <achow101-github@achow101.com> | 2022-08-08 19:07:14 -0400 |
| commit | e7ca8afef62cec200024030272e81a4e3f011822 (patch) | |
| tree | 0a7f8447fc45dea1d6b0ad3e9969c1c7a8afea09 /share/setup.nsi.in | |
| parent | 9ff6adc43abb3c6c35fb43511b1a98178bfbbff1 (diff) | |
| parent | 68006c10abbfec0f16b90efa69b7880a5e17f186 (diff) | |
| download | bitcoin-e7ca8afef62cec200024030272e81a4e3f011822.tar.xz | |
Merge bitcoin/bitcoin#25782: test: check that `verifymessage` RPC fails for non-P2PKH addresses
68006c10abbfec0f16b90efa69b7880a5e17f186 test: check that `verifymessage` RPC fails for non-P2PKH addresses (Sebastian Falbesoner)
Pull request description:
This PR adds missing test coverage for the `verifymessage` RPC, for the case that a non-P2PKH (but otherwise valid) address is passed:
https://github.com/bitcoin/bitcoin/blob/e09ad284c762a79d59417389e9056c18e25d9770/src/util/message.cpp#L38-L40
https://github.com/bitcoin/bitcoin/blob/e09ad284c762a79d59417389e9056c18e25d9770/src/rpc/signmessage.cpp#L48-L49
The passed addresses to trigger the error are of the types nested segwit (P2SH-P2WPKH) and native segwit (P2WPKH) and are created with a helper function `addresses_from_privkey` using descriptors and the `deriveaddresses` RPC. At some point in the future, if we have BIP322 support, all those will likely succeed and can then be moved from error-throwing to the succedding assert loop.
ACKs for top commit:
achow101:
ACK 68006c10abbfec0f16b90efa69b7880a5e17f186
w0xlt:
ACK https://github.com/bitcoin/bitcoin/pull/25782/commits/68006c10abbfec0f16b90efa69b7880a5e17f186
Tree-SHA512: fec4ed97460787c2ef3d04e3fce89c9365c87207c8358b59c41890f3738355c002e64f289ab4aef794ef4dfd5c867be8b67d736fb620489204f2c6bfb8d3363c
Diffstat (limited to 'share/setup.nsi.in')
0 files changed, 0 insertions, 0 deletions