aboutsummaryrefslogtreecommitdiff
path: root/qa/rpc-tests/p2p-acceptblock.py
diff options
context:
space:
mode:
authorJohn Newbery <john@johnnewbery.com>2017-02-07 14:27:57 -0500
committerJohn Newbery <john@johnnewbery.com>2017-03-07 16:45:09 -0500
commit6d07c62322f60eb2702c6654e994fc353bcfcf8c (patch)
tree89db84adb0aac0551740cbdc6fb0260a07be7304 /qa/rpc-tests/p2p-acceptblock.py
parent47510ad3dd514e04caa364ff56ab2cc83569efb9 (diff)
Return correct error codes in bumpfee().
The bumpfee() RPC was returning misleading or incorrect error codes (for example RPC_INVALID_ADDRESS_OR_KEY when the transaction was not BIP125 replacable). This commit fixes those error codes: - RPC_INVALID_ADDRESS_OR_KEY if an invalid address was provided: - Invalid change address given - RPC_INVALID_PARAMETER if a single (non-address/key) parameter is incorrect - confTarget and totalFee options should not both be set. - Invalid confTarget - Insufficient totalFee (cannot be less than required fee) - RPC_WALLET_ERROR for any other error - Transaction has descendants in the wallet - Transaction has descendants in the mempool - Transaction has been mined, or is conflicted with a mined transaction - Transaction is not BIP 125 replaceable - Transaction has already been bumped - Transaction contains inputs that don't belong to the wallet - Transaction has multiple change outputs - Transaction does not have a change output - Fee is higher than maxTxFee - New fee rate is less than the minimum fee rate - Change output is too small. This commit also updates the test cases to explicitly test the error code.
Diffstat (limited to 'qa/rpc-tests/p2p-acceptblock.py')
0 files changed, 0 insertions, 0 deletions