aboutsummaryrefslogtreecommitdiff
path: root/qa/rpc-tests/README.md
diff options
context:
space:
mode:
authorWladimir J. van der Laan <laanwj@gmail.com>2015-12-04 13:10:58 +0100
committerWladimir J. van der Laan <laanwj@gmail.com>2015-12-07 12:45:14 +0100
commitb2d7ada3727f026ccd83d3d64c75aab660d8053e (patch)
tree142613073843d1f0f9ba82a3a56a116734081513 /qa/rpc-tests/README.md
parent82aff880d32f73bae28aa2cc071348ada603159b (diff)
downloadbitcoin-b2d7ada3727f026ccd83d3d64c75aab660d8053e.tar.xz
test: remove necessity to call create_callback_map
Remove necessity to call create_callback_map (as well as the function itself) from the Python P2P test framework. Invoke the appropriate methods directly. - Easy to forget to call it and wonder why it doesn't work - Simplifies the code - This makes it easier to handle new messages in subclasses Github-Pull: #7171 Rebased-From: 2f601d215da1683ae99ab9973219044c32fa2093
Diffstat (limited to 'qa/rpc-tests/README.md')
-rw-r--r--qa/rpc-tests/README.md5
1 files changed, 1 insertions, 4 deletions
diff --git a/qa/rpc-tests/README.md b/qa/rpc-tests/README.md
index 898931936b..651b01f18a 100644
--- a/qa/rpc-tests/README.md
+++ b/qa/rpc-tests/README.md
@@ -47,10 +47,7 @@ implements the test logic.
* ```NodeConn``` is the class used to connect to a bitcoind. If you implement
a callback class that derives from ```NodeConnCB``` and pass that to the
```NodeConn``` object, your code will receive the appropriate callbacks when
-events of interest arrive. NOTE: be sure to call
-```self.create_callback_map()``` in your derived classes' ```__init__```
-function, so that the correct mappings are set up between p2p messages and your
-callback functions.
+events of interest arrive.
* You can pass the same handler to multiple ```NodeConn```'s if you like, or pass
different ones to each -- whatever makes the most sense for your test.