diff options
author | Wladimir J. van der Laan <laanwj@gmail.com> | 2014-06-05 10:10:52 +0200 |
---|---|---|
committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2014-06-23 10:38:15 +0200 |
commit | fa126effc2a03e22708960344e62fc21259deb23 (patch) | |
tree | bb21fb6b131efe0dd5448765c5240ba208d54945 /pkg.m4 | |
parent | 52d4abfdef93cd622b297a092eb6639e678bcb9d (diff) | |
download | bitcoin-fa126effc2a03e22708960344e62fc21259deb23.tar.xz |
Avoid undefined behavior using CFlatData in CScript serialization
`&vch[vch.size()]` and even `&vch[0]` on vectors can cause assertion
errors with VC in debug mode. This is the problem mentioned in #4239.
The deeper problem with this is that we rely on undefined behavior.
- Add `begin_ptr` and `end_ptr` functions that get the beginning and end
pointer of vector in a reliable way that copes with empty vectors and
doesn't reference outside the vector
(see https://stackoverflow.com/questions/1339470/how-to-get-the-address-of-the-stdvector-buffer-start-most-elegantly/1339767#1339767).
- Add a convenience constructor to CFlatData that wraps a vector.
I added `begin_ptr` and `end_ptr` as separate functions as I imagine
they will be useful in more places.
Diffstat (limited to 'pkg.m4')
0 files changed, 0 insertions, 0 deletions