diff options
| author | laanwj <126646+laanwj@users.noreply.github.com> | 2022-06-17 22:44:32 +0200 |
|---|---|---|
| committer | laanwj <126646+laanwj@users.noreply.github.com> | 2022-06-17 22:51:42 +0200 |
| commit | f8586b25f6a4f1e30a54e58f45dd28aaf580bbc6 (patch) | |
| tree | 55d9f3abf82e28db99f74be45f7e5c56193091ab /doc | |
| parent | e5df0ba0d97e5f8cfd748f09d6ed77b7bfc45471 (diff) | |
| parent | dcf36fe8e3e1fc1e865072232281b72889586e40 (diff) | |
| download | bitcoin-f8586b25f6a4f1e30a54e58f45dd28aaf580bbc6.tar.xz | |
Merge bitcoin/bitcoin#25289: test: implement 'bech32m' mode for `getnewdestination()` helper
dcf36fe8e3e1fc1e865072232281b72889586e40 test: implement 'bech32m' mode for `getnewdestination()` helper (Sebastian Falbesoner)
1999dcfa40ddedb6cf15f9d66b90fa0f537b4842 test: add helpers for creating P2TR scripts/addresses from output key (Sebastian Falbesoner)
Pull request description:
This PR adds the missing 'bech32m' mode for the `getnewdestination()` helper and sets it as default, i.e. the function returns a tuple (output x-only-pubkey, scriptPubKey, taproot address) now if not specified otherwise. In a preparation commit, the helpers `output_key_to_p2tr{_script}` are introduced. Note that in contrast to all other common script output types, there are usually _two_ keys involved in creating a taproot output (internal key and output key), hence the prefix `output_` is used to clarify that the output key is expected and the helpers don't do any key tweaking.
Thanks to michaelfolkson (for pointing out this TODO that I forgot about) and sipa (for patiently explaining basic things about BIP341).
ACKs for top commit:
michaelfolkson:
ACK dcf36fe8e3e1fc1e865072232281b72889586e40
w0xlt:
reACK https://github.com/bitcoin/bitcoin/pull/25289/commits/dcf36fe8e3e1fc1e865072232281b72889586e40
Tree-SHA512: 5bb8d5fd96c63092ede10c3f022ffb2e13c14e333c4aa73348d95deb70cbf0a74745218dc4a7c419eb846793dd69e8217a7b4332a13ae2b2758e100b51fb1a9f
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions