diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-04-04 13:17:23 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-04-04 13:17:31 -0400 |
| commit | daef20fb50c00240ea4a5d653f3a47ee604d25c1 (patch) | |
| tree | b5ede2b93e323d480b6b0b8509b8147773d77a81 /doc | |
| parent | ba54342c9dd3f2e5cdeed9ac57f1924f0d885cc6 (diff) | |
| parent | fabfb79673d6bf9bff5258cd709d8294e77c1764 (diff) | |
| download | bitcoin-daef20fb50c00240ea4a5d653f3a47ee604d25c1.tar.xz | |
Merge #15596: rpc: Ignore sendmany::minconf as dummy value
fabfb79673 doc: Add release notes for 15596 (MarcoFalke)
fac1a0fe54 wallet: Remove unused GetLegacyBalance (MarcoFalke)
faa3a246e8 scripted-diff: wallet: Rename pcoin to wtx (MarcoFalke)
fae5f874d5 rpc: Document that minconf is an ignored dummy value (MarcoFalke)
Pull request description:
Other RPCs such as `sendtoaddress` don't have this option at all and `sendmany` should by default spend from (lets say) our change.
ACKs for commit fabfb7:
jnewbery:
utACK fabfb79673d6bf9bff5258cd709d8294e77c1764
ryanofsky:
utACK fabfb79673d6bf9bff5258cd709d8294e77c1764. Nice writeup! Release notes are only change since previous review.
Tree-SHA512: 2526ead2330be7c2beb78b96bc5e55440566c4a3a809bbbd66f5c9fc517f6890affa5d14005dc102644d49679a374510f9507255e870cf88aaa63e429beef658
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/release-notes.md | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/doc/release-notes.md b/doc/release-notes.md index ebcdcda306..a876b70ba7 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -66,9 +66,21 @@ platform. Notable changes =============== -Example item +Updated RPCs ------------ +Note: some low-level RPC changes mainly useful for testing are described in the +Low-level Changes section below. + +* The `sendmany` RPC had an argument `minconf` that was not well specified and + would lead to RPC errors even when the wallet's coin selection would succeed. + The `sendtoaddress` RPC never had this check, so to normalize the behavior, + `minconf` is now ignored in `sendmany`. If the coin selection does not + succeed due to missing coins, it will still throw an RPC error. Be reminded + that coin selection is influenced by the `-spendzeroconfchange`, + `-limitancestorcount`, `-limitdescendantcount` and `-walletrejectlongchains` + command line arguments. + Low-level changes ================= |