diff options
| author | fanquake <fanquake@gmail.com> | 2020-11-18 20:07:58 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-11-18 20:45:46 +0800 |
| commit | 5bcae7967f73353aff5e6d2f696bbf47ec6fdbb3 (patch) | |
| tree | 5ad264620a8c2782881444c826ce9b3fa06a48cf /doc | |
| parent | a64ff1c4d32c0458660426e4f40b45b8b7c13a87 (diff) | |
| parent | 9d09132be4ff99f98ca905c342347d5f35f13350 (diff) | |
| download | bitcoin-5bcae7967f73353aff5e6d2f696bbf47ec6fdbb3.tar.xz | |
Merge #20408: CConnman: move initialization to declaration
9d09132be4ff99f98ca905c342347d5f35f13350 CConnman: initialise at declaration rather than in Start() (Anthony Towns)
Pull request description:
Ensure nMaxOutboundTotalBytesSentInCycle and nMaxOutboundCycleStartTime are initialized even if CConnman::Start() is not called. Prevents failures in test/fuzz/connman when run under valgrind.
ACKs for top commit:
practicalswift:
ACK 9d09132be4ff99f98ca905c342347d5f35f13350: patch looks correct!
MarcoFalke:
review ACK 9d09132be4ff99f98ca905c342347d5f35f13350 , checked that we call Start only once and in the same scope where connman is constructed (AppInitMain) 💸
jnewbery:
Code review ACK 9d09132be4
Tree-SHA512: 1c6c893e8c616a91947a8cc295b0ba508af3ecfcdcd94cdc5f95d808cc93c6d1a71fd24dcc194dc583854e9889fb522ca8523043367fb0263370fbcab08c6aaa
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions