diff options
author | John Newbery <john@johnnewbery.com> | 2017-12-11 12:08:33 -0500 |
---|---|---|
committer | John Newbery <john@johnnewbery.com> | 2017-12-19 11:20:12 -0500 |
commit | 2e029845919eedcb4c4ff5f951cc85d95da68ad1 (patch) | |
tree | feac4789f1ca03f23b8a5f7e31c4bd0b81e99994 /doc | |
parent | dbfe294805a094ba4ed6178a56d0a7588fcd8c27 (diff) |
[tests] node_network_limited - remove race condition
node_network_limited had a race condition, since wait_for_block()
doesn't do what you might expect. It only checks the most recent block
received over the P2P interface (perhaps we should rename the method
wait_for_most_recent_block() to avoid future confusion). The test can
fail if the node sends us invs for other blocks, we respond with a
getdata, and the node sends us one of those blocks in the 0.05 second
wait_until loop window.
Fix this by not responding to inv messages with getdata messages.
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions