aboutsummaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorBtcDrak <btcdrak@gmail.com>2015-09-24 14:28:07 +0100
committerBtcDrak <btcdrak@gmail.com>2015-09-26 09:03:47 +0100
commit06d92d71a2ef414543940fd6ef1080176eb455bb (patch)
treefd5d9e96923ec22d197d66d4514a7d2ce8267788 /doc
parentef4945f2218789d521da81fa9348a85eaef24b6f (diff)
Add CONTRIBUTING.md
Diffstat (limited to 'doc')
-rw-r--r--doc/developer-notes.md17
1 files changed, 2 insertions, 15 deletions
diff --git a/doc/developer-notes.md b/doc/developer-notes.md
index 7d3d78adfc..8302a78562 100644
--- a/doc/developer-notes.md
+++ b/doc/developer-notes.md
@@ -1,5 +1,5 @@
-Coding
-====================
+Coding Standards
+================
Various coding styles have been used during the history of the codebase,
and the result is not very consistent. However, we're now trying to converge to
@@ -171,16 +171,3 @@ Threads
- BitcoinMiner : Generates bitcoins (if wallet is enabled).
- Shutdown : Does an orderly shutdown of everything.
-
-Pull Request Terminology
-------------------------
-
-Concept ACK - Agree with the idea and overall direction, but have neither reviewed nor tested the code changes.
-
-utACK (untested ACK) - Reviewed and agree with the code changes but haven't actually tested them.
-
-Tested ACK - Reviewed the code changes and have verified the functionality or bug fix.
-
-ACK - A loose ACK can be confusing. It's best to avoid them unless it's a documentation/comment only change in which case there is nothing to test/verify; therefore the tested/untested distinction is not there.
-
-NACK - Disagree with the code changes/concept. Should be accompanied by an explanation.