diff options
| author | W. J. van der Laan <laanwj@protonmail.com> | 2021-12-06 10:37:53 +0100 |
|---|---|---|
| committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-12-06 12:18:17 +0100 |
| commit | 22feb7fee9accf1c9f11b896dbfbbe828a1bd056 (patch) | |
| tree | 0a726a3e491288867d81f4b80bb79a26329490c4 /doc | |
| parent | d20d6ac545159fb98bd9ac828678ddf20f5d016d (diff) | |
| parent | a4fe70171b6fa570eda71d86b59d0fb24c2f0614 (diff) | |
Merge bitcoin/bitcoin#23577: Follow-ups to Bech32 error detection
a4fe70171b6fa570eda71d86b59d0fb24c2f0614 Make Bech32 LocateErrors return error list rather than using out-arg (Samuel Dobson)
2fa4fd196176160a5ad0a25da173ff93252b8103 Use std::iota instead of manually pushing range (Samuel Dobson)
405c96fc9fd909ccc461f10d55dfdd822b76f5bf Use bounds-checked array lookups in Bech32 error detection code (Samuel Dobson)
28d9c2857f1c430069bffe0547d12800c84ed9ec Simplify encoding of e in GF(1024) tables to (1,0) (Samuel Dobson)
14358a029def2334ac60d6eb630c60db6dc06f9d Replace GF1024 tables and syndrome constants with compile-time generated constexprs. (Samuel Dobson)
63f7b6977989b93e13c3afd8dfd22b524842b9d7 Update release note for bech32 error detection (Samuel Dobson)
c8b9a224e70f70ccc638b2c4200a505cdf024efd Report encoding type in bech32 error message (Samuel Dobson)
92f0cafdca11a9463b6f04229c1c47805c97c1b5 Improve Bech32 boost tests (Samuel Dobson)
bb4d3e9b970be2a8de3e146623801fc8cbbeb0c7 Address review comments for Bech32 error validation (Samuel Dobson)
Pull request description:
A number of follow-ups and improvements to the bech32 error location code, introduced in #16807.
Notably, this removes the hardcoded GF1024 tables in favour of constexpr table generation.
ACKs for top commit:
laanwj:
Re-ACK a4fe70171b6fa570eda71d86b59d0fb24c2f0614
Tree-SHA512: 6312373c20ebd6636f5797304876fa0d70fa777de2f6c507245f51a652b3d1224ebc55b236c9e11e6956c1e88e65faadab51d53587078efccb451455aa2e2276
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/release-notes-16807.md | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/doc/release-notes-16807.md b/doc/release-notes-16807.md index 5027550a99..3cdd0b36af 100644 --- a/doc/release-notes-16807.md +++ b/doc/release-notes-16807.md @@ -1,6 +1,10 @@ Updated RPCs ------------ -- The `validateaddress` RPC now optionally returns an `error_locations` array, with the indices of -invalid characters in the address. For example, this will return the locations of up to two Bech32 -errors.
\ No newline at end of file +- The `validateaddress` RPC now returns an `error_locations` array for invalid +addresses, with the indices of invalid character locations in the address (if +known). For example, this will attempt to locate up to two Bech32 errors, and +return their locations if successful. Success and correctness are only guaranteed +if fewer than two substitution errors have been made. +The error message returned in the `error` field now also returns more specific +errors when decoding fails.
\ No newline at end of file |