aboutsummaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorWladimir J. van der Laan <laanwj@gmail.com>2014-04-11 09:16:15 +0200
committerWladimir J. van der Laan <laanwj@gmail.com>2014-04-11 09:16:24 +0200
commitf406af3573a2c632fd874562fecdffdd41431af7 (patch)
treead022a95c9ffcf126a6834b8b1d2f19127b75418 /doc
parent4c6cab2c5dbc6ce00970a3e579f7dd5dbcfcf03a (diff)
parent8414cb04949e2b1b6811b338a3c854df577a3b76 (diff)
downloadbitcoin-f406af3573a2c632fd874562fecdffdd41431af7.tar.xz
Merge pull request #4016
8414cb0 Doxygen-compatible comments in coding style (Wladimir J. van der Laan)
Diffstat (limited to 'doc')
-rw-r--r--doc/coding.md57
1 files changed, 55 insertions, 2 deletions
diff --git a/doc/coding.md b/doc/coding.md
index ab3a73494a..69388c9ce2 100644
--- a/doc/coding.md
+++ b/doc/coding.md
@@ -43,8 +43,61 @@ Common types:
set set or multiset
bn CBigNum
--------------------------
+Doxygen comments
+-----------------
+
+To facilitate the generation of documentation, use doxygen-compatible comment blocks for functions, methods and fields.
+
+For example, to describe a function use:
+```c++
+/**
+ * ... text ...
+ * @param[in] arg1 A description
+ * @param[in] arg2 Another argument description
+ * @pre Precondition for function...
+ */
+bool function(int arg1, const char *arg2)
+```
+A complete list of `@xxx` commands can be found at http://www.stack.nl/~dimitri/doxygen/manual/commands.html.
+As Doxygen recognizes the comments by the delimiters (`/**` and `*/` in this case), you don't
+*need* to provide any commands for a comment to be valid, just a description text is fine.
+
+To describe a class use the same construct above the class definition:
+```c++
+/**
+ * Alerts are for notifying old versions if they become too obsolete and
+ * need to upgrade. The message is displayed in the status bar.
+ * @see GetWarnings()
+ */
+class CAlert
+{
+```
+
+To describe a member or variable use:
+```c++
+int var; //!< Detailed description after the member
+```
+
+Also OK:
+```c++
+///
+/// ... text ...
+///
+bool function2(int arg1, const char *arg2)
+```
+
+Not OK (used plenty in the current source, but not picked up):
+```c++
+//
+// ... text ...
+//
+```
+
+A full list of comment syntaxes picked up by doxygen can be found at http://www.stack.nl/~dimitri/doxygen/manual/docblocks.html,
+but if possible use one of the above styles.
+
Locking/mutex usage notes
+-------------------------
The code is multi-threaded, and uses mutexes and the
LOCK/TRY_LOCK macros to protect data structures.
@@ -60,8 +113,8 @@ between the various components is a goal, with any necessary locking
done by the components (e.g. see the self-contained CKeyStore class
and its cs_KeyStore lock for example).
--------
Threads
+-------
- ThreadScriptCheck : Verifies block scripts.