diff options
| author | Samuel Dobson <dobsonsa68@gmail.com> | 2020-06-21 20:37:31 +1200 |
|---|---|---|
| committer | Samuel Dobson <dobsonsa68@gmail.com> | 2020-06-21 20:52:34 +1200 |
| commit | 6bb5f6d8e31853a30a46a82fffef121fd15d2581 (patch) | |
| tree | f437071248f6aabf7db8db4af54b5c357d2a1c6c /doc | |
| parent | bd331bd745fcfd109542d381d928cb244457bb2a (diff) | |
| parent | e5327f947c310849e1ddbb24321e4c9f85564549 (diff) | |
| download | bitcoin-6bb5f6d8e31853a30a46a82fffef121fd15d2581.tar.xz | |
Merge #16377: [rpc] don't automatically append inputs in walletcreatefundedpsbt
e5327f947c310849e1ddbb24321e4c9f85564549 [rpc] fundrawtransaction: add_inputs option to control automatic input adding (Sjors Provoost)
79804fe24bd00e183382dfbcab9343960d158aa5 [rpc] walletcreatefundedpsbt: don't automatically append inputs (Sjors Provoost)
Pull request description:
When the user doesn't specificy inputs, it makes sense to automatically select them. But when the user does specify inputs, `walletcreatefundedpsbt` now fails if the amount is insufficient, unless `addInputs` is set to `true`.
Similarly for `fundrawtransaction` if the original transaction already specified inputs, we only add more if `addInputs` is set to `true`.
This protects against fat finger mistakes in the amount or fee rate (see also #16257). The behavior is also more similar to GUI coin selection.
ACKs for top commit:
achow101:
ACK e5327f947c310849e1ddbb24321e4c9f85564549
meshcollider:
utACK e5327f947c310849e1ddbb24321e4c9f85564549
Tree-SHA512: d8653b820914396c7c25b0d0a2b7e92de214aa023bc1aa085feb37d3b20fab361ebea90416a7db989f19bdc37e26cf0adfbcb712c80985c87afa67a9bd44fecb
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/release-notes-16377.md | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/doc/release-notes-16377.md b/doc/release-notes-16377.md new file mode 100644 index 0000000000..3442fa451b --- /dev/null +++ b/doc/release-notes-16377.md @@ -0,0 +1,9 @@ +RPC changes +----------- +- The `walletcreatefundedpsbt` RPC call will now fail with + `Insufficient funds` when inputs are manually selected but are not enough to cover + the outputs and fee. Additional inputs can automatically be added through the + new `add_inputs` option. + +- The `fundrawtransaction` RPC now supports `add_inputs` option that when `false` + prevents adding more inputs if necessary and consequently the RPC fails. |