diff options
| author | MeshCollider <dobsonsa68@gmail.com> | 2019-08-01 19:10:18 +1200 |
|---|---|---|
| committer | MeshCollider <dobsonsa68@gmail.com> | 2019-08-01 19:11:01 +1200 |
| commit | 6841b013402dbe5e9902e9c89809e80349ded694 (patch) | |
| tree | 2483196e124c3646ff2be0a4ab8276aaa627fb4c /doc | |
| parent | b7fbf74b980ebb122ae34b142f2cc49b44b92de3 (diff) | |
| parent | c5d37873677551caac34752214dd491f5278c8d5 (diff) | |
| download | bitcoin-6841b013402dbe5e9902e9c89809e80349ded694.tar.xz | |
Merge #16394: Allow createwallet to take empty passwords to make unencrypted wallets
c5d37873677551caac34752214dd491f5278c8d5 Allow createwallet to take empty passwords to make unencrypted wallets (Andrew Chow)
Pull request description:
Allow createwallet to take the empty string as a password and interpret that as leaving the wallet unencrypted. Also warn when that happens.
This fixes a bug where it was not possible to use the `avoid_reuse` option for new unencrypted wallets without using named arguments.Thus this allows more `createwallet` options to be added that can be set on unencrypted wallets when using positional arguments.
ACKs for top commit:
jnewbery:
code review ACK c5d37873677551caac34752214dd491f5278c8d5
meshcollider:
re-utACK c5d37873677551caac34752214dd491f5278c8d5
ryanofsky:
utACK c5d37873677551caac34752214dd491f5278c8d5. Changes since last review are rebasing, concatenating warning strings to avoid discarding warnings, adding release notes, and choosing an unambiguous wallet name for the test.
Tree-SHA512: 146737a728dd614ba94d4b166b27e8c9e195badd1709ccab2315afe59176d9b493dfba9b61c3ed81090f059c7e464d709deb06d99451b9a3fff667f527d6f7c9
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/release-notes-16394.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/doc/release-notes-16394.md b/doc/release-notes-16394.md new file mode 100644 index 0000000000..f09cba4b6d --- /dev/null +++ b/doc/release-notes-16394.md @@ -0,0 +1,4 @@ +RPC changes +----------- +`createwallet` now returns a warning if an empty string is used as an encryption password, and does not encrypt the wallet, instead of raising an error. +This makes it easier to disable encryption but also specify other options when using the `bitcoin-cli` tool. |