diff options
author | Jonas Schnelli <dev@jonasschnelli.ch> | 2019-01-23 20:43:38 -1000 |
---|---|---|
committer | Jonas Schnelli <dev@jonasschnelli.ch> | 2019-01-23 20:43:53 -1000 |
commit | 73a6bac9fffab49974736e4baefac271e89e27fc (patch) | |
tree | 3fe39de4c7eeba1712d3d23072dcab4443c513fe /doc | |
parent | 82cf6813a4ef1b4a5439eb6cddb1ab426f3c31a2 (diff) | |
parent | fdf82ba1813cf12e2794bbe20f7d002eaf4279fc (diff) | |
download | bitcoin-73a6bac9fffab49974736e4baefac271e89e27fc.tar.xz |
Merge #15196: [test]: Update all subprocess.check_output functions to be Python 3.4 compatible
fdf82ba18 Update all subprocess.check_output functions in CI scripts to be Python 3.4 compatible (Graham Krizek)
Pull request description:
CI is failing the `lint` stage on every Cron run (regular PR/Push runs still pass). The failure was introduced in 74ce326 and has been broken since. The Python version running in CI was downgraded to 3.4 from 3.6. There were a couple files that were using the `encoding` argument in the `subprocess.check_output` function. This was introduced in Python 3.6 and therefore broke the scripts that were using it. The `universal_newlines` argument was used as well, but in order to use it we must be able to set encoding because of issues on some BSD systems.
To get CI to pass, I removed all `universal_newline` and `encoding` args to the `check_ouput` function. Then I decoded all `check_output` return values. This should keep the same behavior but be Python 3.4 compatible.
Tree-SHA512: f5e5885e98cf4777be9cc254446a873eedb03bdccbd8e06772a964db95e9fcf46736aa9cdcab1d8f123ea9f4947ed6020679898d8b2f47ffb1d94c21a4b08209
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions