diff options
| author | fanquake <fanquake@gmail.com> | 2020-02-20 20:10:40 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-02-20 20:28:46 +0800 |
| commit | 56fc2dfcc3e61a05f6e54c2479897162c8ae4c75 (patch) | |
| tree | 81cbfdd57500ebb0b70d86f64fb8096bd028314d /doc | |
| parent | eddcbfb109e592fdf39ea2c38c4d7ba183de3e34 (diff) | |
| parent | 7f1475c7119e8c72bce39a63386a6ca859066b80 (diff) | |
Merge #18122: rpc: update validateaddress RPCExamples to bech32
7f1475c7119e8c72bce39a63386a6ca859066b80 rpc: update validateaddress RPCExamples to bech32 (Sebastian Falbesoner)
Pull request description:
Another small step to get rid of legacy addresses in the RPC help texts and by that encourage the use of bech32 addresses by default. The (invalid) address is the same as in the `getaddressinfo` RPC (see 2ee0cb3330ccf70f0540cb42370796e32eff1569, kudos to jonatack!), I don't think it adds any value to have a different example address per RPC.
ACKs for top commit:
fanquake:
ACK 7f1475c7119e8c72bce39a63386a6ca859066b80
MarcoFalke:
ACK 7f1475c7119e8c72bce39a63386a6ca859066b80
Tree-SHA512: 2350f61fa942a9053f9f5c860ea446965dc7209c71c81bdb98a859d03ca23b225ad72c9c506e4a55c8d8988823d9cfbe808c1a452a1eeadb70ab186b146dd4ca
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/developer-notes.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/doc/developer-notes.md b/doc/developer-notes.md index a82ecee7d8..d106aab3e4 100644 --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -1089,7 +1089,8 @@ A few guidelines for introducing and reviewing new RPC interfaces: new RPC is replacing a deprecated RPC, to avoid both RPCs confusingly showing up in the command list. -- Use *invalid* bech32 addresses for `RPCExamples` help documentation. +- Use *invalid* bech32 addresses (e.g. the constant `EXAMPLE_ADDRESS`) for + `RPCExamples` help documentation. - *Rationale*: Prevent accidental transactions by users and encourage the use of bech32 addresses by default. |