diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-05-17 11:27:20 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-05-17 11:27:22 -0400 |
| commit | 277abed604a81be8036458573d052eaa293b6cf8 (patch) | |
| tree | c312ff2e9a4fb8279cdbf65cce0cf7eca1fb5683 /doc | |
| parent | a822a0e4f6317f98cde6f0d5abe952b4e8992ac9 (diff) | |
| parent | faede747b3493544f25d601b8e02c833e54c8751 (diff) | |
| download | bitcoin-277abed604a81be8036458573d052eaa293b6cf8.tar.xz | |
Merge #15922: doc: Explain how to pass in non-fundamental types into functions
faede747b3 doc: Explain how to pass in non-fundamental types into functions (MarcoFalke)
Pull request description:
There is a common misconception in C++ that one ampersand is better than no ampersand and two ampersands are better than one.
ACKs for commit faede7:
practicalswift:
ACK faede747b3493544f25d601b8e02c833e54c8751
jonasschnelli:
ACK faede747b3493544f25d601b8e02c833e54c8751
Tree-SHA512: be12c23287398e4525f16e13de30e51a42d9e38284644eed5b67fa23197b09436d75a3aa8db08555ee91a38a0f159d2722b8a9927ce0bc906e600d2a7976086b
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/developer-notes.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/doc/developer-notes.md b/doc/developer-notes.md index cf071167c4..45e55b7c40 100644 --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -478,6 +478,14 @@ Wallet General C++ ------------- +For general C++ guidelines, you may refer to the [C++ Core +Guidelines](https://isocpp.github.io/CppCoreGuidelines/). + +Common misconceptions are clarified in those sections: + +- Passing (non-)fundamental types in the [C++ Core + Guideline](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-conventional) + - Assertions should not have side-effects - *Rationale*: Even though the source code is set to refuse to compile |