diff options
| author | Jon Atack <jon@atack.com> | 2019-09-14 19:48:38 +0200 |
|---|---|---|
| committer | Jon Atack <jon@atack.com> | 2019-09-14 20:17:19 +0200 |
| commit | 0f34f54888f680bfbe7a29ac278636d7178a99bb (patch) | |
| tree | 220005265c9f1dfe46cef7d60b7cf0695b001ee6 /doc | |
| parent | 4bfef0daeb9351c200b5bd09e60596a29b4d3523 (diff) | |
| download | bitcoin-0f34f54888f680bfbe7a29ac278636d7178a99bb.tar.xz | |
rpc: fix regression in gettransaction
PR 16866 renamed the 'decode' argument in gettransaction to 'verbose' to make it more consistent with other RPC calls like getrawtransaction.
However, it seems it inadvertently overloaded the 'details' fields when 'verbose' is passed. The result is that the original 'details' fields are no longer returned, which seems to be a breaking API change.
This PR takes the simplest path to restoring the 'details' fields by renaming them from 'details' back to 'decoded', while leaving the 'verbose' argument for API consistency.
It also addresses [this comment](https://github.com/bitcoin/bitcoin/pull/16185#discussion_r320740413) to mention that the 'decoded' field is identical to decoderawtransaction.
Update the RPC help, functional test, and release note.
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/release-notes-16185.md | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/doc/release-notes-16185.md b/doc/release-notes-16185.md index 14e4004f72..2567ebea40 100644 --- a/doc/release-notes-16185.md +++ b/doc/release-notes-16185.md @@ -1,3 +1,6 @@ RPC changes ----------- -The `gettransaction` RPC now accepts a third (boolean) argument `verbose`. If set to `true`, a new `details` field will be added to the response containing additional transaction details. +The `gettransaction` RPC now accepts a third (boolean) argument `verbose`. If +set to `true`, a new `decoded` field will be added to the response containing +the decoded transaction. This field is equivalent to RPC `decoderawtransaction`, +or RPC `getrawtransaction` when `verbose` is passed. |