diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-01-19 17:44:27 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-01-19 17:46:17 +0100 |
| commit | f4c942e3615435c9e5d7ff0cefd935be08768d0c (patch) | |
| tree | fb8d7b36d94846595de88fae91df70ec1edc8b89 /doc | |
| parent | 9a97f39afaa890caa7987c6bc001b9a66e3e74e8 (diff) | |
| parent | ec527c6c88146d5b36de38a1fcebe4f6ea72bd1b (diff) | |
| download | bitcoin-f4c942e3615435c9e5d7ff0cefd935be08768d0c.tar.xz | |
Merge #12220: Error if relative -walletdir is specified
ec527c6 Don't allow relative -walletdir paths (Russell Yanofsky)
Pull request description:
This makes it an error to explicitly specify a non-absolute -walletdir path, and also adds a debug.log warning if a relative rather than absolute -datadir path is configured.
Specifying paths relative to the current working directory in a daemon process can be dangerous, because files can fail to be located even if the configuration doesn't change, but the daemon is started up differently.
Specifying a relative -datadir now adds a warning to the debug log. It would not be backwards-compatible to forbid relative -datadir paths entirely, and it could also be inconvenient for command line testing.
Specifying a relative -walletdir now results in a startup error. But since the -walletdir option is new in 0.16.0, there should be no compatibility issues. Another reason not to use working directory paths for -walletdir specifically is that the default -walletdir is a "wallets" subdirectory inside the datadir, so it could be surprising that setting -walletdir manually would choose a directory rooted in a completely different location.
Tree-SHA512: 67cbdae677f82487a9031c5ec96b0205a488ab08718a0f4f49365e025119f3d7f6cfc88ba1eba04c1ecd8b9561a5b2c42e2e1a267af7c08c76b83e5e361f5a31
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/release-notes.md | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/doc/release-notes.md b/doc/release-notes.md index ecca08d96d..29377d4a1d 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -90,9 +90,8 @@ bitcoin data directory. The behavior is now: already exists in the data directory root, then wallets will be stored in the `wallets/` subdirectory by default. - The location of the wallets directory can be overridden by specifying a - `-walletdir=<path>` option where `<path>` can be an absolute path or a - relative path (relative to the current working directory). `<path>` can - also be a path to symlink to a directory. + `-walletdir=<path>` option where `<path>` can be an absolute path to a + directory or directory symlink. Care should be taken when choosing the wallets directory location, as if it becomes unavailable during operation, funds may be lost. |