diff options
author | fanquake <fanquake@gmail.com> | 2020-02-12 08:35:41 +0800 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2020-02-12 08:50:07 +0800 |
commit | 73a396e0280a40be55bf1acf9abef2f81999a440 (patch) | |
tree | d73167285f7aff6eae3c2d8cd11f78eed88ab4aa /doc/release-process.md | |
parent | 98264e2ccb177a6603fe957f7e263fb413b50d04 (diff) | |
parent | cb9e88e73a042ff4e1c83289a6f8fa1db03fb093 (diff) | |
download | bitcoin-73a396e0280a40be55bf1acf9abef2f81999a440.tar.xz |
Merge #18004: build: don't embed a build-id when building libdmg-hfsplus
cb9e88e73a042ff4e1c83289a6f8fa1db03fb093 build: don't embed a build-id when building libdmg-hfsplus (fanquake)
Pull request description:
There was a [reproducibility issue (IRC logs)](http://www.erisian.com.au/bitcoin-core-dev/log-2020-01-25.html) with the osx `0.19.1rc1` gitian builds. The `build-id` embedded into the `dmg` tool was mismatching. It's possible that differing versions of binutils/ld were the cause.
While it was resolved after rebuilding the base gitian image, whether an upstream package issue or fluke, we can remove the possibility of it happening in future by just not embedding a build-id into the `dmg` tool at all. Can close if it's not deemed worth it.
You can test this change using the following:
```bash
# build libdmg
make native_libdmg-hfsplus_built -C depends/ HOST=x86_64-apple-darwin16 -j6 V=1
# master
readelf --string-dump .note.gnu.build-id /bitcoin/depends/work/build/x86_64-apple-darwin16/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-3830944ef98/build/dmg/dmg
String dump of section '.note.gnu.build-id':
[ c] GNU
[ 11] CjRa?]?^V8?v?;%n??
# this pr
readelf --string-dump .note.gnu.build-id /bitcoin/depends/work/build/x86_64-apple-darwin16/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-a72f53ab110/build/dmg/dmg
readelf: Warning: Section '.note.gnu.build-id' was not dumped because it does not exist!
```
ACKs for top commit:
laanwj:
tested ACK cb9e88e73a042ff4e1c83289a6f8fa1db03fb093
Tree-SHA512: 191eed32ed0a04a908f9c1b22188180b2db2f35bae0281940f0f9da2450c5c6807cd6ff5bbcce7c933a9133387b127c3478f7a39a2918c14f17be19fd9ea19b4
Diffstat (limited to 'doc/release-process.md')
0 files changed, 0 insertions, 0 deletions