diff options
| author | fanquake <fanquake@gmail.com> | 2019-08-14 14:19:39 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2019-08-14 14:46:00 +0800 |
| commit | 05ccbe9a299116c50d6e99042c1eb4e45119c78a (patch) | |
| tree | b64400d5aedd26b7cf87e3bfbb355d44601747e1 /doc/release-notes | |
| parent | c3b605cf130187d8da0b79e6b7e99ad231d2c031 (diff) | |
| parent | afc0966d725aeeb8842dc264bd48f0e9c41f6a34 (diff) | |
Merge #16598: test: Remove confusing hash256 function in util
afc0966d725aeeb8842dc264bd48f0e9c41f6a34 Moved and renamed hash256 from util.py to zmq_interface.py (Elichai Turkel)
Pull request description:
Right now there are two `hash256(bytes)` in the test framework:
first: https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L186
second: https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/messages.py#L60
While they have the same name they're actually doing different things, one just does a sha256d and the other sha256d and reverses the bytes.
so I renamed the second one to be `hash256r` to signify that it's hash256 reversed.
ACKs for top commit:
MarcoFalke:
unsigned ACK afc0966d725aeeb8842dc264bd48f0e9c41f6a34
fanquake:
ACK afc0966d725aeeb8842dc264bd48f0e9c41f6a34
Tree-SHA512: fb0e2db6f09c0248d92f2fd72d05a78cec1bebb44449239dbeecefa62cf4bd01d180b2e6dbcee48a8a9cea79a909e224256cabdd0739f334c2943647fe0c5fe4
Diffstat (limited to 'doc/release-notes')
0 files changed, 0 insertions, 0 deletions