diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-05-14 09:11:48 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-05-14 09:16:33 -0400 |
| commit | 65526fc8666fef35ef908dbc225f706bef642c7e (patch) | |
| tree | b3efbfc6d0378c7d3dc9c78d2c24f274b1d451ac /doc/productivity.md | |
| parent | 3503a69ba23714546944205dfeacfd557dd2e56c (diff) | |
| parent | f1a77b0c5176306ca9f6f30211e32d3502ed4281 (diff) | |
| download | bitcoin-65526fc8666fef35ef908dbc225f706bef642c7e.tar.xz | |
Merge #15777: [docs] Add doxygen comments for keypool classes
f1a77b0c51 [docs] Add doxygen comment for CReserveKey (John Newbery)
37796b2dd4 [docs] Add doxygen comment for CKeyPool (John Newbery)
ef2d515af3 [wallet] move-only: move CReserveKey to be next to CKeyPool (John Newbery)
Pull request description:
Docs/move-only
Adds doxygen comments for the CKeyPool and CReserveKey objects. The way these work is pretty confusing and it's easy to overlook details (eg https://github.com/bitcoin/bitcoin/pull/15557#discussion_r271956393).
These are on the verbose side, but I think too much commenting is better than not enough. Happy to take feedback on what's an appropriate level.
ACKs for commit f1a77b:
jonatack:
Thanks, John. Re-ACK f1a77b0c5176306ca9f6f30211e32d3502ed4281, doc-only changes with respect to previous review.
jb55:
ACK f1a77b0c5176306ca9f6f30211e32d3502ed4281
Tree-SHA512: 8bc97c7029cd2e8d9bfd2d2144eeff73474c71eda5a9d10817e1578ca0b70da677252037d83143faaff1808e2193408a21a8a89d36049eac77fd313990f0b67b
Diffstat (limited to 'doc/productivity.md')
0 files changed, 0 insertions, 0 deletions