diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-01-16 19:23:15 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-01-16 19:23:33 +0100 |
| commit | f018d0c9cd7f408dac016b6bfc873670de713d27 (patch) | |
| tree | 507d9547263ae63a37c5a5e03c5a5838fc88dbfa /doc/developer-notes.md | |
| parent | a9c789ed964dbfae59585e3b56c35816afc3d95e (diff) | |
| parent | 6dd59d2e491bc11ab26498668543e65440a3a931 (diff) | |
| download | bitcoin-f018d0c9cd7f408dac016b6bfc873670de713d27.tar.xz | |
Merge #17924: Bug: IsUsedDestination shouldn't use key id as script id for ScriptHash
6dd59d2e491bc11ab26498668543e65440a3a931 Don't allow implementers to think ScriptHash(Witness*()) results in nesting computation (Gregory Sanders)
4b8f1e989f3b969dc628b0801d5c31ebd373719c IsUsedDestination shouldn't use key id as script id for ScriptHash (Gregory Sanders)
Pull request description:
Regression introduced in https://github.com/bitcoin/bitcoin/pull/17621 which causes p2sh-segwit addresses to be erroneously missed.
Tests are only failing in 0.19 branch, likely because that release still uses p2sh-segwit addresses rather than bech32 by default.
I'll devise a test case to catch this going forward.
ACKs for top commit:
achow101:
ACK 6dd59d2e491bc11ab26498668543e65440a3a931
MarcoFalke:
ACK 6dd59d2
meshcollider:
Code review ACK 6dd59d2e491bc11ab26498668543e65440a3a931
Tree-SHA512: b3e0f320c97b8c1f814cc386840240cbde2761fee9711617b713d3f75a4a5dce2dff2df573d80873df42a1f4b74e816ab8552a573fa1d62c344997fbb6af9950
Diffstat (limited to 'doc/developer-notes.md')
0 files changed, 0 insertions, 0 deletions