diff options
| author | fanquake <fanquake@gmail.com> | 2020-01-14 08:24:35 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-01-14 08:53:34 +0800 |
| commit | a4a93a0badb328c4e54c3ceb7cc29a740bce5e43 (patch) | |
| tree | c37a8c1722a432d77f0b5a586b6ef071c623dd74 /doc/developer-notes.md | |
| parent | 2ed74a43a05a47129d56117deeb489addbcaf05f (diff) | |
| parent | 8313fa8e8112e429e104b7e7fd48e5e6e359b82e (diff) | |
Merge #17906: gui: Set CConnman byte counters earlier to avoid uninitialized reads
8313fa8e8112e429e104b7e7fd48e5e6e359b82e gui: Set CConnman byte counters earlier to avoid uninitialized reads (Russell Yanofsky)
Pull request description:
Initialize CConnman byte counters during construction, so GetTotalBytesRecv() and GetTotalBytesSent() methods don't return garbage before Start() is called.
Change shouldn't have any effect outside of the GUI. It just fixes a race condition during a qt test that was observed on travis: https://travis-ci.org/bitcoin/bitcoin/jobs/634989685
ACKs for top commit:
MarcoFalke:
ACK 8313fa8e8112e429e104b7e7fd48e5e6e359b82e
promag:
ACK 8313fa8e8112e429e104b7e7fd48e5e6e359b82e.
Tree-SHA512: 97c246da4e28e6e0b48f685b840f96746ad75c4b157a692201c6c4702db328a88ead8507d8e1b4e608aa1882513174ec60cf3977c31b7a9d76678cc9f49b45f8
Diffstat (limited to 'doc/developer-notes.md')
0 files changed, 0 insertions, 0 deletions