aboutsummaryrefslogtreecommitdiff
path: root/doc/developer-notes.md
diff options
context:
space:
mode:
authorMarcoFalke <falke.marco@gmail.com>2019-11-06 15:18:34 -0500
committerMarcoFalke <falke.marco@gmail.com>2019-11-06 15:18:41 -0500
commite65b4160e99fa86d6d840dce75cae29334afd1f2 (patch)
tree1f875be3f3a98df9b0193623510a7b426bcf9393 /doc/developer-notes.md
parent976cc766c42889b6d1042e4cda39045d5001f406 (diff)
parentaf7bae734089f6af0029b0887932ccd9a469e12e (diff)
downloadbitcoin-e65b4160e99fa86d6d840dce75cae29334afd1f2.tar.xz
Merge #17340: Tests: speed up fundrawtransaction test
af7bae734089f6af0029b0887932ccd9a469e12e [tests] Don't stop-start unnecessarily in rpc_fundrawtransaction.py (John Newbery) 9a8505299ba392acbab4647963113b0c29495f1d [tests] Use -whitelist in rpc_fundrawtransaction.py (John Newbery) 646b593bbd0db113c6e45ab92177b8f5251e8710 [tests] Speed up rpc_fundrawtransaction.py (John Newbery) Pull request description: Speed up rpc_fundrawtransaction.py Most of the time in rpc_fundrawtransaction.py is spent waiting for unconfirmed transactions to propagate. Net processing adds a poisson random delay to the time it will INV transactions with a mean interval of 5 seconds. Calls like the following: ``` self.nodes[2].sendrawtransaction(signedTx['hex']) self.sync_all() self.nodes[1].generate(1) ```` will therefore introduce a delay waiting for the mempools to sync. Instead just generate the block on the node that sent the transaction: ``` self.nodes[2].sendrawtransaction(signedTx['hex']) self.nodes[2].generate(1) ``` rpc_fundrawtransaction.py is not intended to be a test for transaction relay, so it's ok to do this. ACKs for top commit: MarcoFalke: ACK af7bae734089f6af0029b0887932ccd9a469e12e 🛴 Tree-SHA512: db3407d871bfdc99a02e7304b07239dd3585ac47f27f020f1a70608b7f6386b134343c01f3e4d1c246ce734676755897671999695068d6388602fb042d178780
Diffstat (limited to 'doc/developer-notes.md')
0 files changed, 0 insertions, 0 deletions