aboutsummaryrefslogtreecommitdiff
path: root/doc/developer-notes.md
diff options
context:
space:
mode:
authorKaz Wesley <keziahw@gmail.com>2016-06-08 13:26:18 -0700
committerKaz Wesley <keziahw@gmail.com>2016-06-09 09:59:06 -0700
commit654a21162252294b7dbd6c982fec88008af7335e (patch)
tree068ff786c16b4280fd1d5d5fa1146800e240e20a /doc/developer-notes.md
parent52c3f348bec33fab5ae0a9f1b9f14b9a74c0083f (diff)
downloadbitcoin-654a21162252294b7dbd6c982fec88008af7335e.tar.xz
developer notes: updates for C++11
- boost::scoped_ptr is obsolete - std::vector::data replaces begin_ptr / end_ptr
Diffstat (limited to 'doc/developer-notes.md')
-rw-r--r--doc/developer-notes.md9
1 files changed, 4 insertions, 5 deletions
diff --git a/doc/developer-notes.md b/doc/developer-notes.md
index add2fb5004..94bd86203e 100644
--- a/doc/developer-notes.md
+++ b/doc/developer-notes.md
@@ -265,7 +265,7 @@ General C++
the `.h` to the `.cpp` should not result in build errors
- Use the RAII (Resource Acquisition Is Initialization) paradigm where possible. For example by using
- `scoped_pointer` for allocations in a function.
+ `unique_ptr` for allocations in a function.
- *Rationale*: This avoids memory and resource leaks, and ensures exception safety
@@ -284,10 +284,9 @@ C++ data structures
- *Rationale*: Behavior is undefined. In C++ parlor this means "may reformat
the universe", in practice this has resulted in at least one hard-to-debug crash bug
-- Watch out for vector out-of-bounds exceptions. `&vch[0]` is illegal for an
- empty vector, `&vch[vch.size()]` is always illegal. Use `begin_ptr(vch)` and
- `end_ptr(vch)` to get the begin and end pointer instead (defined in
- `serialize.h`)
+- Watch out for out-of-bounds vector access. `&vch[vch.size()]` is illegal,
+ including `&vch[0]` for an empty vector. Use `vch.data()` and `vch.data() +
+ vch.size()` instead.
- Vector bounds checking is only enabled in debug mode. Do not rely on it