diff options
| author | W. J. van der Laan <laanwj@protonmail.com> | 2021-09-23 16:55:37 +0200 |
|---|---|---|
| committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-09-23 16:55:47 +0200 |
| commit | d8b4b3077fd20c90b635eff1dd240bdad9725027 (patch) | |
| tree | eca1841ee7dd5f3b6c7c7b338eb0cbc06a7521e7 /doc/build-windows.md | |
| parent | 95b16e70a8b7ebd103e0ada62a7449184fc9200c (diff) | |
| parent | 64e1ddd255771e57a88a20f07dbde04a83bf0c75 (diff) | |
Merge bitcoin/bitcoin#23057: log: Consolidate timedata logging
64e1ddd255771e57a88a20f07dbde04a83bf0c75 log: call LogPrint only once with time data samples (Martin Zumsande)
Pull request description:
When timedata samples are logged, `LogPrint()` is currently invoked multiple times on the same log entry.
This can lead to chaos in the log when other threads log concurrently, as in this example which motivated this PR:
```
2021-09-20T00:28:57Z -48 -26 -11 -8 -6 Addrman checks started: new 37053, tried 83, total 37136
2021-09-20T00:28:57Z -3 -1 -1 -1 -1 +0 | nTimeOffset = -3 (+0 minutes)
```
Fix this by building the log message in a string and logging it one `LogPrint()` call. I also changed the wording slightly so that it becomes understandable what is being logged, example:
```
2021-09-21T21:03:24Z time data samples: -43 -18 -12 -4 -1 -1 +0 +0 +268 | median offset = -1 (+0 minutes)
```
ACKs for top commit:
jnewbery:
Tested ACK 64e1ddd255
laanwj:
Tested ACK 64e1ddd255771e57a88a20f07dbde04a83bf0c75, new message lgtm
Tree-SHA512: ffb7a93166cc8fd6a39200b9e03a9d1e8e975b7ded822ccddd015f553258b991162a5cb867501f426d3ebcfef4f32f0e06e17b18e6b01486b967595d102f8379
Diffstat (limited to 'doc/build-windows.md')
0 files changed, 0 insertions, 0 deletions