diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-11-05 10:32:24 +0100 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-11-05 10:32:39 +0100 |
| commit | 50422b770a40f5fa964201d1e99fd6b5dc1653ca (patch) | |
| tree | b8171f95f5c41b823ae6c0b075e0a8659a8f0366 /doc/JSON-RPC-interface.md | |
| parent | ce57dbac90b06272a037cb3c9ce1fd67d0c66199 (diff) | |
| parent | 25ef049d60535ac02508ba71ef60f17d8349f120 (diff) | |
Merge bitcoin/bitcoin#26419: log: mempool: log removal reason in validation interface
25ef049d60535ac02508ba71ef60f17d8349f120 log: mempool: log removal reason in validation interface (James O'Beirne)
Pull request description:
Currently the exact reason a transaction is removed from the mempool isn't logged. It is sometimes detectable from context, but adding the `reason` to the validation interface logs (where it is already passed) seems like an easy way to disambiguate.
For example in the case of mempool expiry, the logs look like this:
```
[validationinterface.cpp:220] [TransactionRemovedFromMempool] [validation] Enqueuing TransactionRemovedFromMempool: txid=<txid> wtxid=<wtxid>
[txmempool.cpp:1050] [RemoveUnbroadcastTx] [mempool] Removed <txid> from set of unbroadcast txns before confirmation that txn was sent out
[validationinterface.cpp:220] [operator()] [validation] TransactionRemovedFromMempool: txid=<txid> wtxid=<wtxid>
[validation.cpp:267] [LimitMempoolSize] [mempool] Expired 1 transactions from the memory pool
```
There is no context-free way to know $txid was evicted on the basis of expiry. This change will make that case (and probably others) clear.
ACKs for top commit:
0xB10C:
ACK 25ef049d60535ac02508ba71ef60f17d8349f120
Tree-SHA512: 9890f9fa16f66c8a9296798d8c28993e1b81da17cf592946f2abc22041f0b30b0911ab86a0c48d4aa46b9a8b3f7f5de67778649ac48c97740b0a09aa6816e0af
Diffstat (limited to 'doc/JSON-RPC-interface.md')
0 files changed, 0 insertions, 0 deletions