diff options
author | fanquake <fanquake@gmail.com> | 2019-10-18 14:13:19 -0400 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2019-10-18 14:23:47 -0400 |
commit | ddc3cf26ff1272e905f31406d1f365a3c3c6bd9e (patch) | |
tree | 7a2ff556b7814cbd6b76be3f6cffbc27b6007bae /depends | |
parent | 0ff7cd7d0c074448db636bcc73e7879b7e4b21ec (diff) | |
parent | cc3b5289ef648dca30469ee4afa615a1ed5b4e04 (diff) | |
download | bitcoin-ddc3cf26ff1272e905f31406d1f365a3c3c6bd9e.tar.xz |
Merge #17151: gui: remove OpenSSL PRNG seeding (Windows, Qt only)
cc3b5289ef648dca30469ee4afa615a1ed5b4e04 gui: remove OpenSSL PRNG seeding (Windows, Qt only) (fanquake)
Pull request description:
This removes the code introduced in [#4399](https://github.com/bitcoin/bitcoin/pull/4399) that attempts to add additional entroy to the OpenSSL PRNG using `RAND_event()`. This is specific to bitcoin-qt running on Windows.
```
RAND_event() collects the entropy from Windows events such as mouse movements and other user interaction.
It should be called with the iMsg, wParam and lParam arguments of all messages sent to the window procedure.
It will estimate the entropy contained in the event message (if any), and add it to the PRNG.
The program can then process the messages as usual.
```
Besides BIP70, this is the last place we are directly using OpenSSL in the GUI code. All other OpenSSL usage is in [random.cpp](https://github.com/bitcoin/bitcoin/blob/master/src/random.cpp).
Note that we are still also still doing other Windows specific gathering using [RandAddSeedPerfmon](https://github.com/bitcoin/bitcoin/blob/master/src/random.cpp#L268) and [RAND_screen()](https://github.com/bitcoin/bitcoin/blob/master/src/random.cpp#L600) on top of the other generation we do.
Also note that if RAND_event returns `0` here (PRNG has **NOT** been seeded with enough data), we're just logging a single message and continuing, which also seems less than ideal.
ACKs for top commit:
laanwj:
ACK cc3b5289ef648dca30469ee4afa615a1ed5b4e04
MarcoFalke:
unsigned ACK cc3b5289ef648dca30469ee4afa615a1ed5b4e04
theuni:
ACK cc3b5289ef648dca30469ee4afa615a1ed5b4e04.
Tree-SHA512: 0bb18779cf37f6670e3e5ac6a6a38e5f95199491b2684f9e56391c76f030fe1621d6df064239c2a398f228129fdf3f2220fc8cd15b2b92ecf2ea6d98a79b2175
Diffstat (limited to 'depends')
0 files changed, 0 insertions, 0 deletions