diff options
| author | Carl Dong <contact@carldong.me> | 2020-07-10 17:37:51 -0400 |
|---|---|---|
| committer | Carl Dong <contact@carldong.me> | 2020-07-10 21:05:55 -0400 |
| commit | 60c55b1b9bab8c1e143e2f4c26d729bfa0bbcf09 (patch) | |
| tree | 80cc6c05a99fa3ccf626e13933e954e4613bfe4a /depends | |
| parent | 6b8e497eeaf38f272715c490f317fdc98a2174be (diff) | |
| download | bitcoin-60c55b1b9bab8c1e143e2f4c26d729bfa0bbcf09.tar.xz | |
depends: Add justifications for macOS clang flags
Diffstat (limited to 'depends')
| -rw-r--r-- | depends/hosts/darwin.mk | 24 |
1 files changed, 22 insertions, 2 deletions
diff --git a/depends/hosts/darwin.mk b/depends/hosts/darwin.mk index 3cda45a2bd..6099fd4c71 100644 --- a/depends/hosts/darwin.mk +++ b/depends/hosts/darwin.mk @@ -6,8 +6,28 @@ LD64_VERSION=530 OSX_SDK=$(SDK_PATH)/Xcode-$(XCODE_VERSION)-$(XCODE_BUILD_ID)-extracted-SDK-with-libcxx-headers -# When cross-compiling for Darwin using Clang, -mlinker-version must be passed to -# ensure that modern linker features are enabled. +# Flag explanations: +# +# -mlinker-version +# +# Ensures that modern linker features are enabled. See here for more +# details: https://github.com/bitcoin/bitcoin/pull/19407. +# +# -B$(build_prefix)/bin +# +# Explicitly point to our binaries (e.g. cctools) so that they are +# ensured to be found and preferred over other possibilities. +# +# -nostdinc++ -isystem $(OSX_SDK)/usr/include/c++/v1 +# +# Forces clang to use the libc++ headers from our SDK and completely +# forget about the libc++ headers from the standard directories +# +# TODO: Once we start requiring a clang version that has the +# -stdlib++-isystem<directory> flag first introduced here: +# https://reviews.llvm.org/D64089, we should use that instead. Read the +# differential summary there for more details. +# darwin_CC=clang -target $(host) -mmacosx-version-min=$(OSX_MIN_VERSION) --sysroot $(OSX_SDK) -mlinker-version=$(LD64_VERSION) -B$(build_prefix)/bin darwin_CXX=clang++ -target $(host) -mmacosx-version-min=$(OSX_MIN_VERSION) --sysroot $(OSX_SDK) -stdlib=libc++ -mlinker-version=$(LD64_VERSION) -B$(build_prefix)/bin -nostdinc++ -isystem $(OSX_SDK)/usr/include/c++/v1 |