aboutsummaryrefslogtreecommitdiff
path: root/depends
diff options
context:
space:
mode:
authorRyan Ofsky <ryan@ofsky.org>2024-04-29 10:14:38 -0400
committerRyan Ofsky <ryan@ofsky.org>2024-04-29 10:38:50 -0400
commit19865a8350a8181ab658bef48976a728bae6a8bd (patch)
tree0b8576a6427020b25a66d61c77c4cad726a8b629 /depends
parent0c45d73f185d0f09c9b0b5a1749f405fb8125887 (diff)
parent30a6c999351041d6a1e8712a9659be1296a1b46a (diff)
Merge bitcoin/bitcoin#29277: RPC: access RPC arguments by name
30a6c999351041d6a1e8712a9659be1296a1b46a rpc: access some args by name (stickies-v) bbb31269bfa449e82d3b6a20c2c3481fb3dcc316 rpc: add named arg helper (stickies-v) 13525e0c248eab9b199583cde76430c6da2426e2 rpc: add arg helper unit test (stickies-v) Pull request description: Adds string overloads for the `RPCHelpMan::Arg` and `RPCHelpMan::MaybeArg` helpers to be able to access RPC arguments by name instead of index number. Especially in RPCs with a large number of parameters, this can be quite helpful. Example usage: ```cpp const auto action{self.Arg<std::string>("action")}; ``` Most of the LoC is adding test coverage and documentation updates. No behaviour change. An alternative approach to #27788 with significantly less overhaul. ACKs for top commit: fjahr: Code review ACK 30a6c999351041d6a1e8712a9659be1296a1b46a maflcko: ACK 30a6c999351041d6a1e8712a9659be1296a1b46a 🥑 ryanofsky: Code review ACK 30a6c999351041d6a1e8712a9659be1296a1b46a. Nice change! Implementation is surprisingly simple and additional unit test coverage is welcome, too. Tree-SHA512: 4904f5f914fe1d421d32f60edb7c5a028c8ea0f140a2f207a106b4752d441164e073066a6bf2e17693f859fe847815a96609d3cf521e0ac4178d8cd09362ea3d
Diffstat (limited to 'depends')
0 files changed, 0 insertions, 0 deletions