diff options
| author | fanquake <fanquake@gmail.com> | 2021-11-28 09:50:11 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-11-28 09:51:45 +0800 |
| commit | 4f8b1f8759301d2553183e14f72444a0f1d80725 (patch) | |
| tree | a4798555b616ce41f6a4f58083866fff1257a155 /contrib | |
| parent | 4aa06f944768bd81022ef29096a1021433cfa482 (diff) | |
| parent | b79dbe86a9886b3539512f6c35205f4c5454a952 (diff) | |
| download | bitcoin-4f8b1f8759301d2553183e14f72444a0f1d80725.tar.xz | |
Merge bitcoin/bitcoin#23608: test: fix `feature_rbf.py --descriptors` and add to test runner
b79dbe86a9886b3539512f6c35205f4c5454a952 test: add feature_rbf.py --descriptors to test_runner.py (Sebastian Falbesoner)
166f8ec28e48aa4c0cd94544909c488df553d8ef test: always rescan after importing private keys in `init_wallet` helper (Sebastian Falbesoner)
Pull request description:
The functional test feature_rbf.py currently fails on master branch, if descriptor wallets are used (argument `--descriptors`). This is due to the fact that in this case, a call to the helper `init_wallet`
https://github.com/bitcoin/bitcoin/blob/111c3e06b35b7867f2e0f740e988f648ac6c325d/test/functional/test_framework/test_framework.py#L428-L434
creates a wallet without rescanning the blockchain; the test framework maps the importprivkey RPC calls to the importdescriptors RPC without rescanning by default (timestamp='now'). Fix this by always calling with `rescan=True`, which calls importdescriptors with timestamp=0. Also add `feature_rbf.py --descriptors` to the list of the test runner's calls.
Fixes #23563.
ACKs for top commit:
mjdietzx:
ACK b79dbe86a9886b3539512f6c35205f4c5454a952
Tree-SHA512: a3f3f7a4077066e3c910919d3b5e04bc6b580c1e0a06e9a2fc258950eaea5e59c0f805c8f00432aea722609f2f7e41eebfab653471b76729c5a316825a3d8c86
Diffstat (limited to 'contrib')
0 files changed, 0 insertions, 0 deletions