diff options
author | MarcoFalke <falke.marco@gmail.com> | 2021-07-22 20:09:32 +0200 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2021-07-22 20:13:43 +0200 |
commit | 7925f3aba820f8965293148ef666c59f87dd3c7f (patch) | |
tree | b6a11ac207fbdc5fa35d4e357be0328e25336e8c /contrib | |
parent | 5d83e7d714e0b7cafeb2f14892184a9607cb55dc (diff) | |
parent | 78f4c8b98eada337346ffb206339c3ebae4ff43b (diff) | |
download | bitcoin-7925f3aba820f8965293148ef666c59f87dd3c7f.tar.xz |
Merge bitcoin/bitcoin#22383: rpc: Prefer to use txindex if available for GetTransaction
78f4c8b98eada337346ffb206339c3ebae4ff43b prefer to use txindex if available for GetTransaction (Jameson Lopp)
Pull request description:
Fixes #22382
Motivation: prevent excessive disk reads if txindex is enabled.
Worth noting that this could be argued to be less of a bug and more of an issue of undefined behavior. If a user calls GetTransaction with the wrong block hash, what should happen?
ACKs for top commit:
jonatack:
ACK 78f4c8b98eada337346ffb206339c3ebae4ff43b
theStack:
Code review ACK 78f4c8b98eada337346ffb206339c3ebae4ff43b
LarryRuane:
tACK 78f4c8b98eada337346ffb206339c3ebae4ff43b
luke-jr:
utACK 78f4c8b98eada337346ffb206339c3ebae4ff43b
jnewbery:
utACK 78f4c8b98eada337346ffb206339c3ebae4ff43b
rajarshimaitra:
Code review ACK https://github.com/bitcoin/bitcoin/commit/78f4c8b98eada337346ffb206339c3ebae4ff43b
lsilva01:
Code Review ACK and Tested ACK https://github.com/bitcoin/bitcoin/pull/22383/commits/78f4c8b98eada337346ffb206339c3ebae4ff43b on Ubuntu 20.04
Tree-SHA512: af7db5b98cb2ae4897b28476b2fa243bf7e6f850750d9347062fe8013c5720986d1a3c808f80098e5289bd84b085de03c81a44e584dc28982f721c223651bfe0
Diffstat (limited to 'contrib')
0 files changed, 0 insertions, 0 deletions