diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-10-17 10:55:09 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-10-17 10:55:19 +0200 |
| commit | 3bf40d06a22ee1c547d2924d109b8e185ddbf5ef (patch) | |
| tree | 65db1ba717a255212cb4e29941dbadf1fb74c09d /contrib | |
| parent | feedb9c84e72e4fff489810a2bbeec09bcda5763 (diff) | |
| parent | a46f71bb703dd8ada77e5eaf2a0b05d741d39bbf (diff) | |
| download | bitcoin-3bf40d06a22ee1c547d2924d109b8e185ddbf5ef.tar.xz | |
Merge bitcoin/bitcoin#23212: lint: enable mypy import checking
a46f71bb703dd8ada77e5eaf2a0b05d741d39bbf lint: enable mypy checking for missing imports (josibake)
22e652662bb1fb9bd7ae6ab01c20665ad1c57895 lint mypy 0.910 (fanquake)
6ae9c2ef23e50733991e2836925006387fda3eb7 lint: install pyzmq (22.3.0) into linter environment (josibake)
b93e2299dab52b513a12b90ddff577055dae10d5 doc: remove pointlessly duplicated linter version / install info (fanquake)
Pull request description:
This is #22844 with issues addressed, and two additional commits. One to move to the latest mypy version in the CI, and another to remove what is just pointless duplication from the test README. There's no need to relist package versions and install instructions (meaning 2x the work when changing anything), when you can just link to `04_install.sh` which has the versions used and pip invocations to install them.
ACKs for top commit:
practicalswift:
cr ACK a46f71bb703dd8ada77e5eaf2a0b05d741d39bbf
Tree-SHA512: 2900dea3901d03a846dc1ea912f217d152e803845516c7d941745ec1291d145590cd4bf2ddc497f7cf628119ba9905d7b1531836062aa85b384e39cf436f62c6
Diffstat (limited to 'contrib')
| -rwxr-xr-x | contrib/devtools/security-check.py | 2 | ||||
| -rwxr-xr-x | contrib/devtools/symbol-check.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/contrib/devtools/security-check.py b/contrib/devtools/security-check.py index c374de4b55..ef421aebb1 100755 --- a/contrib/devtools/security-check.py +++ b/contrib/devtools/security-check.py @@ -10,7 +10,7 @@ Otherwise the exit status will be 1 and it will log which executables failed whi import sys from typing import List -import lief +import lief #type:ignore def check_ELF_RELRO(binary) -> bool: ''' diff --git a/contrib/devtools/symbol-check.py b/contrib/devtools/symbol-check.py index 158b6fa0ff..136a9b70c1 100755 --- a/contrib/devtools/symbol-check.py +++ b/contrib/devtools/symbol-check.py @@ -13,7 +13,7 @@ Example usage: import sys from typing import List, Dict -import lief +import lief #type:ignore # temporary constant, to be replaced with lief.ELF.ARCH.RISCV # https://github.com/lief-project/LIEF/pull/562 |