diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-04-23 06:37:35 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-04-23 06:37:53 -0400 |
| commit | 64139803f1225dab26197a20314109d37fa87d5f (patch) | |
| tree | 5d763cfdfc71e7fa2c12b946fccfe60b5a29e60c /contrib | |
| parent | e890c15e2cc91487ce023900912646ff56ee97b4 (diff) | |
| parent | 9f5608c2893f89cd56c7c548b748996199e0da1d (diff) | |
| download | bitcoin-64139803f1225dab26197a20314109d37fa87d5f.tar.xz | |
Merge #18690: test: Check object hashes in wait_for_getdata
9f5608c2893f89cd56c7c548b748996199e0da1d test: check for matching object hashes in wait_for_getdata (Danny Lee)
Pull request description:
Previously, `wait_for_getdata` only looked for the presence of a recent `"getdata"` message. Additionally checking the object hashes inside the message should make tests involving `wait_for_getdata` more robust.
`p2p_sendheaders.py` already overrides `wait_for_getdata` do this check; we can use the same approach consistently across all tests that call `wait_for_getdata`.
This PR is progress towards #18614 , but closing that issue would also involve some additional changes to `wait_for_getheaders`.
ACKs for top commit:
theStack:
ACK 9f5608c2893f89cd56c7c548b748996199e0da1d :beers:
Tree-SHA512: 8e7f95881c19631db014d4bb2399fea0d14686a32542f6ca3b60809744b0d684eac4e4c107c87143991f3cd0c2d4ab09d0c17486239768a9b40bee25f2e4d54a
Diffstat (limited to 'contrib')
0 files changed, 0 insertions, 0 deletions