diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-01-08 15:14:33 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-01-08 15:14:53 +0100 |
| commit | 9158d6f34153dc937e109d0e7486e956a26f20aa (patch) | |
| tree | afa58ad48fe854ac6d9fb5947e9cd5b702b432c6 /contrib | |
| parent | 1e078f17b5dc94fae329b38057512994532a32de (diff) | |
| parent | faecb74562d012a336837d3b39572c235ad2eb9d (diff) | |
Merge #20786: net: [refactor] Prefer integral types in CNodeStats
faecb74562d012a336837d3b39572c235ad2eb9d Expose integral m_conn_type in CNodeStats, remove m_conn_type_string (Jon Atack)
Pull request description:
Currently, strings are stored for what are actually integral (strong) enum types. This is fine, because the strings are only used as-is for the debug log and RPC. However, it complicates using them in the GUI. User facing strings in the GUI should be translated and only string literals can be picked up for translation, not runtime `std::string`s.
Fix that by removing the `std::string` members and replace them by strong enum integral types.
ACKs for top commit:
jonatack:
Code review ACK faecb74562d012a336837d3b39572c235ad2eb9d
theStack:
Code review ACK faecb74562d012a336837d3b39572c235ad2eb9d 🌲
Tree-SHA512: 24df2bd0645432060e393eb44b8abaf20fe296457d07a867b0e735c3e2e75af7b03fc6bfeca734ec33ab816a7c8e1f8591a5ec342f3afe3098a4e41f5c2cfebb
Diffstat (limited to 'contrib')
0 files changed, 0 insertions, 0 deletions