diff options
author | fanquake <fanquake@gmail.com> | 2021-05-05 15:59:09 +0800 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2021-06-10 10:40:53 +0800 |
commit | 29615aef52d7f1a29a87a29dfe4d39bf0e9867f3 (patch) | |
tree | d761b6a1af00e6bf7ac6fdcfd541d7010dac9c1a /contrib | |
parent | 8732f7b6c92f9dcf37f3ab618e9daab0c52fc781 (diff) |
scripts: check minimum required macOS vesion is set
We use a compile flag (-mmacosx-version-min) to set the minimum required
version of macOS needed to run our binaries. This adds a sanity check
that the version is being set as expected.
Diffstat (limited to 'contrib')
-rwxr-xr-x | contrib/devtools/symbol-check.py | 9 | ||||
-rwxr-xr-x | contrib/devtools/test-symbol-check.py | 15 |
2 files changed, 22 insertions, 2 deletions
diff --git a/contrib/devtools/symbol-check.py b/contrib/devtools/symbol-check.py index d740a94560..5fab2b3285 100755 --- a/contrib/devtools/symbol-check.py +++ b/contrib/devtools/symbol-check.py @@ -212,6 +212,12 @@ def check_MACHO_libraries(filename) -> bool: ok = False return ok +def check_MACHO_min_os(filename) -> bool: + binary = lief.parse(filename) + if binary.build_version.minos == [10,14,0]: + return True + return False + def check_PE_libraries(filename) -> bool: ok: bool = True binary = lief.parse(filename) @@ -228,7 +234,8 @@ CHECKS = { ('LIBRARY_DEPENDENCIES', check_ELF_libraries) ], 'MACHO': [ - ('DYNAMIC_LIBRARIES', check_MACHO_libraries) + ('DYNAMIC_LIBRARIES', check_MACHO_libraries), + ('MIN_OS', check_MACHO_min_os), ], 'PE' : [ ('DYNAMIC_LIBRARIES', check_PE_libraries) diff --git a/contrib/devtools/test-symbol-check.py b/contrib/devtools/test-symbol-check.py index 106dfd2c5a..7cbe55f91d 100755 --- a/contrib/devtools/test-symbol-check.py +++ b/contrib/devtools/test-symbol-check.py @@ -98,7 +98,7 @@ class TestSymbolChecks(unittest.TestCase): self.assertEqual(call_symbol_check(cc, source, executable, ['-lexpat']), (1, 'libexpat.1.dylib is not in ALLOWED_LIBRARIES!\n' + - executable + ': failed DYNAMIC_LIBRARIES')) + executable + ': failed DYNAMIC_LIBRARIES MIN_OS')) source = 'test2.c' executable = 'test2' @@ -114,6 +114,19 @@ class TestSymbolChecks(unittest.TestCase): ''') self.assertEqual(call_symbol_check(cc, source, executable, ['-framework', 'CoreGraphics']), + (1, executable + ': failed MIN_OS')) + + source = 'test3.c' + executable = 'test3' + with open(source, 'w', encoding="utf8") as f: + f.write(''' + int main() + { + return 0; + } + ''') + + self.assertEqual(call_symbol_check(cc, source, executable, ['-mmacosx-version-min=10.14']), (0, '')) def test_PE(self): |