diff options
| author | fanquake <fanquake@gmail.com> | 2020-06-29 14:21:36 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-06-29 14:21:51 +0800 |
| commit | b80ae6b4c04b2b9f8a4181acf450bcd513f27788 (patch) | |
| tree | 59a1247984958dd69bbc7b30127ded0125dbef8f /contrib | |
| parent | 2f54c760504ee61b2358bfeb7cda73898a67652f (diff) | |
| parent | e12e970df6fcae08ff8008812cdeef600d6b2db8 (diff) | |
| download | bitcoin-b80ae6b4c04b2b9f8a4181acf450bcd513f27788.tar.xz | |
Merge #19344: docs: update testgen usage example
e12e970df6fcae08ff8008812cdeef600d6b2db8 docs: match usage text to script and location (Peter Bushnell)
Pull request description:
Update the usage text in the README to match the usage text in the Python script.
https://github.com/bitcoin/bitcoin/blob/02b26ba1c119c7732f09f09e3b94f75effa569c0/contrib/testgen/gen_key_io_test_vectors.py#L9
https://github.com/bitcoin/bitcoin/blob/02b26ba1c119c7732f09f09e3b94f75effa569c0/contrib/testgen/gen_key_io_test_vectors.py#L10
Also to match the file names in the actual destination.
https://github.com/bitcoin/bitcoin/blob/02b26ba1c119c7732f09f09e3b94f75effa569c0/src/test/data/key_io_valid.json
https://github.com/bitcoin/bitcoin/blob/02b26ba1c119c7732f09f09e3b94f75effa569c0/src/test/data/key_io_invalid.json
Following the README usage text generates new files when the user is likely to have wanted to update the existing files.
ACKs for top commit:
fanquake:
ACK e12e970df6fcae08ff8008812cdeef600d6b2db8 - this looks correct.
Tree-SHA512: b7ab61e19a54597a8fbd1844b9cfaef78879e53b882eefe4e0140fa115674df7f061e468835186963b89c963244a17d922f2ad0829b10f62b84f02019ee33edb
Diffstat (limited to 'contrib')
| -rw-r--r-- | contrib/testgen/README.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/contrib/testgen/README.md b/contrib/testgen/README.md index 573a71a675..eaca473b40 100644 --- a/contrib/testgen/README.md +++ b/contrib/testgen/README.md @@ -4,5 +4,5 @@ Utilities to generate test vectors for the data-driven Bitcoin tests. Usage: - PYTHONPATH=../../test/functional/test_framework ./gen_key_io_test_vectors.py valid 50 > ../../src/test/data/key_io_keys_valid.json - PYTHONPATH=../../test/functional/test_framework ./gen_key_io_test_vectors.py invalid 50 > ../../src/test/data/key_io_keys_invalid.json + PYTHONPATH=../../test/functional/test_framework ./gen_key_io_test_vectors.py valid 50 > ../../src/test/data/key_io_valid.json + PYTHONPATH=../../test/functional/test_framework ./gen_key_io_test_vectors.py invalid 50 > ../../src/test/data/key_io_invalid.json |