diff options
| author | Jonas Schnelli <dev@jonasschnelli.ch> | 2018-06-19 09:25:05 +0200 |
|---|---|---|
| committer | Jonas Schnelli <dev@jonasschnelli.ch> | 2018-06-19 09:25:17 +0200 |
| commit | 3f398d7a17f136cd4a67998406ca41a124ae2966 (patch) | |
| tree | 01184f0098e17057498754d7854e8cd5987b8727 /contrib | |
| parent | 088240685456494a26047c8f3d5ecf578f70dbce (diff) | |
| parent | f74894480db5dfbf49534499f489357ee9984183 (diff) | |
| download | bitcoin-3f398d7a17f136cd4a67998406ca41a124ae2966.tar.xz | |
Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock
f74894480 Only set fNewBlock to true in AcceptBlock when we write to disk (Matt Corallo)
fa6e49731 rpc: Avoid "duplicate" return value for invalid submitblock (MarcoFalke)
Pull request description:
This is #13395 with one more commit tacked on. MarcoFalke got tired of dealing with the stupidity of fixing a return code with too many rounds of review (not that I blame him). Honestly we should probably have no return whatsoever, but for now, this fixes it (as well as nLastBlockTime for eviction purposes).
Original description:
When `submitblock` of an invalid block, the return value should not be `"duplicate"`.
This is only seen when the header was previously found (denoted by the incorrectly named boolean `fBlockPresent`). Fix this bug by removing `fBlockPresent`.
Tree-SHA512: 0ce3092655d5d904b4c8c5ff7479f73ce387144a738f20472b8af132564005c6db5594ae366e589508f6258506ee7a28b1c7995a83a8328b334f99316006bf2d
Diffstat (limited to 'contrib')
0 files changed, 0 insertions, 0 deletions