diff options
| author | fanquake <fanquake@gmail.com> | 2020-04-24 17:03:36 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-04-24 17:22:54 +0800 |
| commit | d8ca51db5ddfb51c225c0c99f8aa1f5d68f0ad83 (patch) | |
| tree | 032e37ceebe6b14d0b4e5292f19e91dced3a9257 /contrib/verify-commits/pre-push-hook.sh | |
| parent | 64139803f1225dab26197a20314109d37fa87d5f (diff) | |
| parent | eb37275a6f972c81caef010b4ee9c5dc88edc759 (diff) | |
Merge #18589: Fix naming of macOS SDK and clarify version
eb37275a6f972c81caef010b4ee9c5dc88edc759 Fix naming of macOS SDK and clarify version (Andrew Chow)
Pull request description:
Fixes the `MacOSX10.14.sdk.tar.gz` creation command to have `MacOSX.sdk` be correctly named as `MacOSX10.14.sdk` and for the resulting file to be placed in the current directory. Gitian requires that `tar.gz` contains a folder named `MacOSX10.14.sdk` and the command did not do this originally. Having the file be placed in the current directory is a convenience so builders don't have to go find it.
Also clarifies which version of Xcode to download and where it can be downloaded.
ACKs for top commit:
fanquake:
ACK eb37275a6f972c81caef010b4ee9c5dc88edc759 - tested the macOS and Linux SDK extraction. Also noticed something seemingly broken with Apple `tar`, but will open an issue to follow up.
Sjors:
ACK eb37275 for the macOS instruction
Tree-SHA512: d691e14711cf195999291dd6fb7ffe552c86f8b30d2b1a77e88b4db6050dd817ba128b047cf36d29b0bb0d4183e709b7c03aa27f31b64e562ea8cd948434ca55
Diffstat (limited to 'contrib/verify-commits/pre-push-hook.sh')
0 files changed, 0 insertions, 0 deletions