diff options
| author | fanquake <fanquake@gmail.com> | 2021-08-16 11:00:33 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-08-16 11:23:53 +0800 |
| commit | 820129aee9fdd0b3f238e9feef60330342d61966 (patch) | |
| tree | 78db04821e506a1977b39c700340172224644a29 /contrib/verify-commits/README.md | |
| parent | 11c7d001a9c3b600ee47d5851054e8d5c01a3de1 (diff) | |
| parent | 92885c4f69a5e6fc4989677d6e5be8a666fbff0d (diff) | |
Merge bitcoin/bitcoin#22686: wallet: Use GetSelectionAmount in ApproximateBestSubset
92885c4f69a5e6fc4989677d6e5be8a666fbff0d test: Test for ApproximateBestSubset edge case with too little fees (Andrew Chow)
d9262324e80da32725e21d4e0fbfee56f25490b1 wallet: Assert that enough was selected to cover the fees (Andrew Chow)
2de222c40198d3d528668d78cc52e2ce3fa96765 wallet: Use GetSelectionAmount for target value calculations (Andrew Chow)
Pull request description:
The `m_value` used for the target calculation in `ApproximateBestSubset` is incorrect, it should be `GetSelectionAmount`. This causes a bug that is only apparent when the minimum relay fee is set to be very high.
A test case is added for this, in addition to an assert in `CreateTransactionInternal` that would have also caught this issue if someone were able to hit the edge case.
Fixes #22670
ACKs for top commit:
instagibbs:
utACK https://github.com/bitcoin/bitcoin/pull/22686/commits/92885c4f69a5e6fc4989677d6e5be8a666fbff0d
Tree-SHA512: bd61fa61ffb60873e097737eebea3afe8a42296ba429de9038b3a4706763b34de9409de6cdbab21ff7f51f4787b503f840873182d9c4a1d6e12a54b017953547
Diffstat (limited to 'contrib/verify-commits/README.md')
0 files changed, 0 insertions, 0 deletions