diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2022-04-04 10:06:45 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2022-04-04 10:06:52 +0200 |
| commit | 0da559e02e442f246c18b3d94ed166b97d1fb649 (patch) | |
| tree | 2a41d7eec22ed1d2d66341678e3635e87fcbb435 /contrib/tracing | |
| parent | 62efdfb3be7be129c09506c46b21e5aa14f278cd (diff) | |
| parent | 37a16ffd7011828a8b6fa175bfc1f03be41bb261 (diff) | |
Merge bitcoin/bitcoin#24661: refactor: Use clang-tidy syntax for C++ named arguments
37a16ffd7011828a8b6fa175bfc1f03be41bb261 refactor: fix clang-tidy named args usage (fanquake)
Pull request description:
> Incorrect named args are source of bugs, like https://github.com/bitcoin/bitcoin/pull/22979.
> To allow them being checked by clang-tidy, use a format it can understand.
Picks up #23545, with some additional changes and some feedback addressed.
With these changes invoking `./autogen.sh && ./configure CC=clang-12 CXX=clang++-12 && make clean && bear make -j9 && ( cd ./src/ && run-clang-tidy-12 -j9 )` no-longer results in named argument errors out of `clang-tidy`.
Ultimately I think we should just add `clang-tidy-*` jobs to the CI and automate things away.
ACKs for top commit:
MarcoFalke:
cr ACK 37a16ffd7011828a8b6fa175bfc1f03be41bb261
Tree-SHA512: 9bfc0d006eb187755b4fdb0bd92cee9266fc0816be42065ef7dcd885b9020ff12e3cdd7ca3a831613a56a0206d448e690ee4e1fa37628fa2013860e17f416ff3
Diffstat (limited to 'contrib/tracing')
0 files changed, 0 insertions, 0 deletions