diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2022-01-31 18:04:53 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2022-01-31 18:05:01 +0100 |
| commit | 8f137e69caeb2a2ffe1aa930bd6fbc49cee4087c (patch) | |
| tree | 9d026772be9534b6b3828113e9e32c0c3e26d9f9 /contrib/testgen | |
| parent | 0ff13913287b3874e305535c78bc43b190217168 (diff) | |
| parent | fa7b07571f24b6def6effdd4cc1b96c7507bf959 (diff) | |
Merge bitcoin/bitcoin#24192: test: Fix feature_init intermittent issues
fa7b07571f24b6def6effdd4cc1b96c7507bf959 test: Fix feature_init intermittent issues (MarcoFalke)
fa4595deb334f14dac9ba481d786a823e0f0fde1 test: Remove random line number feature from feature_init.py (MarcoFalke)
Pull request description:
The test doesn't work currently because the log might be finalized before `wait_for_debug_log` is started, in which case it will assume the log is empty and fail to detect any line.
Fix this by calling `wait_for_debug_log` first. Fixes #24060.
Also, remove the "random line number" part of the test, because it doesn't really test anything novel. `wait_for_debug_log` is inherently racy, so will randomly terminate at the exact point or later. So the randomization is already sufficiently covered.
ACKs for top commit:
jamesob:
ACK https://github.com/bitcoin/bitcoin/pull/24192/commits/fa7b07571f24b6def6effdd4cc1b96c7507bf959
mzumsande:
Code Review ACK fa7b07571f24b6def6effdd4cc1b96c7507bf959
Tree-SHA512: f107a04926270a1d9ac8f53b6e5254566d1827ba7d27fd74f9ce909319f8794f8bd46da9c42256bf41b6df26c0bad8b9a0d54e4e148695189af09f31e3948330
Diffstat (limited to 'contrib/testgen')
0 files changed, 0 insertions, 0 deletions