diff options
| author | Jonas Schnelli <dev@jonasschnelli.ch> | 2017-10-03 20:14:58 -0700 |
|---|---|---|
| committer | Jonas Schnelli <dev@jonasschnelli.ch> | 2017-10-03 20:15:11 -0700 |
| commit | 093074b84395a5b562bc378971d29c89da4202a4 (patch) | |
| tree | ba589edf075d55434d1171c70daf0abb2c2673c4 /contrib/testgen | |
| parent | b4a509a3f817121c3df98ddfd96b2769e18a3e5a (diff) | |
| parent | ab5bba7783d2927e513af91e6c89c41bdfa47964 (diff) | |
Merge #11419: Utils: Fix launchctl not being able to stop bitcoind
ab5bba778 Fix launchctl not being able to stop bitcoind (Alejandro Avilés)
Pull request description:
`bitcoind` should not be launched as daemon from the Launch Agent. Otherwise, the process cannot be stopped from `launchctl stop`/`launchctl unload`.
To reproduce the issue:
```console
$ launchctl load ~/Library/LaunchAgents/org.bitcoin.bitcoind.plist
$ pgrep -fla bitcoin
60225 /usr/local/opt/bitcoin/bin/bitcoind
$ launchctl unload ~/Library/LaunchAgents/org.bitcoin.bitcoind.plist
```
Wait a few seconds and then run `pgrep` again:
```console
$ pgrep -fla bitcoin
60225 /usr/local/opt/bitcoin/bin/bitcoind
```
The node is still running. This happens because Launch Agent is not supposed to run programs as daemons, since the agent makes sure they run in the background. Running them as daemons makes the Launch Agent lose control of the process and, so, it cannot be stopped.
Tree-SHA512: 5342e1a858e478a226a1db292f1b8f8666bb252ee951753b131902c325ea3d47592cf245298decb423ac658a3175761b54dc2e7df6feea5343d65ba255613f67
Diffstat (limited to 'contrib/testgen')
0 files changed, 0 insertions, 0 deletions