aboutsummaryrefslogtreecommitdiff
path: root/contrib/testgen
diff options
context:
space:
mode:
authorSamuel Dobson <dobsonsa68@gmail.com>2020-06-21 20:37:31 +1200
committerSamuel Dobson <dobsonsa68@gmail.com>2020-06-21 20:52:34 +1200
commit6bb5f6d8e31853a30a46a82fffef121fd15d2581 (patch)
treef437071248f6aabf7db8db4af54b5c357d2a1c6c /contrib/testgen
parentbd331bd745fcfd109542d381d928cb244457bb2a (diff)
parente5327f947c310849e1ddbb24321e4c9f85564549 (diff)
downloadbitcoin-6bb5f6d8e31853a30a46a82fffef121fd15d2581.tar.xz
Merge #16377: [rpc] don't automatically append inputs in walletcreatefundedpsbt
e5327f947c310849e1ddbb24321e4c9f85564549 [rpc] fundrawtransaction: add_inputs option to control automatic input adding (Sjors Provoost) 79804fe24bd00e183382dfbcab9343960d158aa5 [rpc] walletcreatefundedpsbt: don't automatically append inputs (Sjors Provoost) Pull request description: When the user doesn't specificy inputs, it makes sense to automatically select them. But when the user does specify inputs, `walletcreatefundedpsbt` now fails if the amount is insufficient, unless `addInputs` is set to `true`. Similarly for `fundrawtransaction` if the original transaction already specified inputs, we only add more if `addInputs` is set to `true`. This protects against fat finger mistakes in the amount or fee rate (see also #16257). The behavior is also more similar to GUI coin selection. ACKs for top commit: achow101: ACK e5327f947c310849e1ddbb24321e4c9f85564549 meshcollider: utACK e5327f947c310849e1ddbb24321e4c9f85564549 Tree-SHA512: d8653b820914396c7c25b0d0a2b7e92de214aa023bc1aa085feb37d3b20fab361ebea90416a7db989f19bdc37e26cf0adfbcb712c80985c87afa67a9bd44fecb
Diffstat (limited to 'contrib/testgen')
0 files changed, 0 insertions, 0 deletions