diff options
author | MarcoFalke <falke.marco@gmail.com> | 2019-10-14 10:14:39 -0400 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2019-10-14 10:14:46 -0400 |
commit | 6c7da0736d13bfb96ae934871e7699fd11a8f8f3 (patch) | |
tree | b9f4a9e0b29c1cc24d3bd3d384836941be6acef1 /contrib/macdeploy/README.md | |
parent | 556820ee576d02528de8cc5998579b044b3666c9 (diff) | |
parent | 32d665c2657793c8b2cc7248d26d80a940acfe20 (diff) |
Merge #17108: test: fix "tx-size-small" errors after default address change
32d665c2657793c8b2cc7248d26d80a940acfe20 test: fix "tx-size-small" errors after default address change (Sebastian Falbesoner)
Pull request description:
Addresses #17043, affects RBF and BIP68 functional tests.
The "tx-size-small" policy rule rejects transactions with a non-witness size of
smaller than 82 bytes (see `src/validation.cpp:MemPoolAccept::PreChecks(...)`),
which corresponds to a transaction with 1 segwit input and 1 P2WPKH output.
Through the default address change, the created test transactions have segwit
inputs now and sending to short scriptPubKeys might violate this rule. By
bumping the dummy scriptPubKey size to 22 bytes (= the size of a P2WPKH
scriptPubKey), on all occurences the problem is solved.
The dummy scriptPubKey has the format:
```21 <21-byte-long string of 'a' or 1s>```
ACKs for top commit:
instagibbs:
reACK https://github.com/bitcoin/bitcoin/pull/17108/commits/32d665c2657793c8b2cc7248d26d80a940acfe20 just s/Bytes/bytes/
MarcoFalke:
ACK 32d665c2657793c8b2cc7248d26d80a940acfe20
Tree-SHA512: 80e0386ff3c3f462901ba5c1e5ef2cbf095d9c0a40c8c3cfeacd4a3ab676afe744aa95b9eed77b4b3eec88bed930b33aa718117ed0977f6374e858a2f3bd5c57
Diffstat (limited to 'contrib/macdeploy/README.md')
0 files changed, 0 insertions, 0 deletions